cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Santana <csantan...@gmail.com>
Subject Re: Android target level for CLI
Date Tue, 05 Nov 2013 21:59:44 GMT
Based on CLI Design [1]
The CLI should not hold the code to check requirements (i.e.
src/metadata/android_parser.js)

The CLI instead should delegate to platform by calling
(platform/android/cordova/check_reqs)


Today there is duplicate of code not in sync for Android and iOS (other
platforms delegate to cheq_reqs):
CLI src/metadata/[platform]/check_requirements [2]
Platform cordova/check_reqs [3]



[1]: http://wiki.apache.org/cordova/CommandLineToolingDesign
[2]:
https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
[3]:
https://github.com/apache/cordova-android/blob/master/bin/lib/check_reqs.js


On Tue, Nov 5, 2013 at 4:34 PM, Braden Shepherdson <braden@chromium.org>wrote:

> I don't know how this value got updated in the past, it should presumably
> be set to target the latest version of Android.
>
> +1 for bumping it to 19.
>
> Braden
>
>
> On Tue, Nov 5, 2013 at 4:19 PM, Gorkem Ercan <gorkem.ercan@gmail.com>
> wrote:
>
> > Hello,
> > Does anyone recall the reason for CLI to having "android-17" as a hard
> > target dependency.
> > --
> > Gorkem
> >
>



-- 
Carlos Santana
<csantana23@gmail.com>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message