cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bryan Higgins <br...@bryanhiggins.net>
Subject Re: Cordova CLI minor update
Date Fri, 29 Nov 2013 14:46:03 GMT
Created CB-5507

I'll push it out this afternoon if there are no objections.


On Fri, Nov 29, 2013 at 9:30 AM, Michal Mocny <mmocny@chromium.org> wrote:

> It landed, sorry I forgot to close the issue.
>  (cordova-android 42f4d49fc30ca37fb22309b92f104c2336f70c3f)
>
>
> On Fri, Nov 29, 2013 at 8:46 AM, Bryan Higgins <bryan@bryanhiggins.net
> >wrote:
>
> > Michal - how goes CB-5338? I'd love to get a point release out before the
> > weekend.
> >
> >
> > On Thu, Nov 28, 2013 at 3:16 PM, Bryan Higgins <bryan@bryanhiggins.net
> > >wrote:
> >
> > > I've put a fix in for BB, which unfortunately has to contain custom
> code
> > > paths [1].
> > >
> > > The lazy load was putting files under blackberry10 sub-folder, when
> they
> > > have always lived directly in
> > ~/.cordova/lib/blackberry10/cordova/<VERSION>
> > >
> > > I'm not sure why the windows platforms prefer to have the extra
> > > sub-directory, but we can't change the location for bb10 without also
> > > updating the platform version in platforms.js. There are active users
> who
> > > have already downloaded the 3.2 lib. Hopefully not many have started
> > > cleanly on 3.2.0-0.2.0, which would put them in a bad state.
> > >
> > > [1]
> > >
> >
> https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;a=commit;h=f7a35b3ca8a8b787fbbe01aebed286802451b64a
> > >
> > >
> > > On Thu, Nov 28, 2013 at 10:52 AM, Andrew Grieve <agrieve@chromium.org
> > >wrote:
> > >
> > >> On Thu, Nov 28, 2013 at 10:05 AM, Michal Mocny <mmocny@chromium.org>
> > >> wrote:
> > >>
> > >> > If we are going to land another CLI point release, I suggest we wait
> > for
> > >> > CB-5338 as well to properly fix the android API version bump to 18
> as
> > we
> > >> > planned for 3.2.  That should land soon/today.
> > >> >
> > >> > -Michal
> > >> >
> > >> >
> > >> > On Thu, Nov 28, 2013 at 10:00 AM, Bryan Higgins <
> > bryan@bryanhiggins.net
> > >> > >wrote:
> > >> >
> > >> > > This update breaks BB10 badly.
> > >> > >
> > >> > > There was a change made to attempt standardizing platforms in
> > >> > sub-folders.
> > >> > > I asked yesterday if this had been tested on BB10  The answer
was
> > no.
> > >> > When
> > >> > > I found some time to test it out (just now), it had already been
> > >> merged
> > >> > > into master and released to NPM.
> > >> > >
> > >> > > Perhaps if the commit messages had JIRA ids and something more
> > >> > descriptive
> > >> > > than "merging master from x", we'd have a clue about what we're
> > >> > > releasing...
> > >> > >
> > >> > >
> > >> > > On Wed, Nov 27, 2013 at 4:26 PM, Lorin Beer <
> > lorin.beer.dev@gmail.com
> > >> > > >wrote:
> > >> > >
> > >> > > > Michael and I released another version of the Cordova CLI
this
> > >> morning.
> > >> > > >
> > >> > > > This is a minor version bump, and includes a commit to fix
a
> > >> blocking
> > >> > > issue
> > >> > > > for projects that consume the Cordova CLI as a library.
> > >> >
> > >>
> > >> What is the issue? Is there a JIRA for it?
> > >>
> > >> Sounds like it's unlikely worse than having BB completely broken. I'd
> > like
> > >> someone else to make the call since I'm still catching up on things,
> but
> > >> sounds like we may want to roll back this point release until BB is
> > fixed.
> > >> E.g., make it not "latest" tag in npm.
> > >>
> > >>
> > >> > > >
> > >> > > > This was tested on OSX and Windows before the release, and
> should
> > >> not
> > >> > > > affect the Cordova CLI at all.
> > >> > > >
> > >> > > > In the future, the list will be notified prior before even
a
> minor
> > >> > > release
> > >> > > > like this.
> > >> >
> > >>
> > >> This was already the documented procedure. Bad call it seems :(.
> > >>
> > >>
> > >> >  > >
> > >> > > >
> > >> > > > - Lorin
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message