cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: input type=file broken on Android 4.4
Date Fri, 15 Nov 2013 20:13:02 GMT
This "filling in the gap" is what we were born to do


On Thu, Nov 14, 2013 at 11:10 AM, Brian LeRoux <b@brian.io> wrote:

> Ugly indeed but that is what we do! =)
>
> Probably just a docs issue doing what you describe.
>
>
> On Thu, Nov 14, 2013 at 10:57 AM, Andrew Grieve <agrieve@chromium.org
> >wrote:
>
> > I'll ask around and see if anyone has ideas on fixing it.
> >
> > We could probably polyfill it though, by having a click handler on the
> body
> > looking for clicks on <input type=file>, and then hijacking the
> onsubmit()
> > of the form. Ugly.
> >
> >
> > On Thu, Nov 14, 2013 at 12:09 PM, Brian LeRoux <b@brian.io> wrote:
> >
> > > I think it is reasonable that we choose to allow a polyfill for this
> > > regardless of the Google stance. The change is very likely to break
> > > existing users and just b/c it was 'private' doesn't mean that it
> wasn't
> > > exposed. Maybe this is just a docs issue given we have the scaffolding
> to
> > > fix this with File/FileTransfer.
> > >
> > > ??
> > >
> > >
> > > On Thu, Nov 14, 2013 at 8:39 AM, Joe Bowser <bowserj@gmail.com> wrote:
> > >
> > > > Apologize and say "Sorry, the Android team hates Cordova"?
> > > >
> > > > Honestly, was this a private API that was in the Android Browser
> code?
> > > > If so, then we should assume that this would break, since this wasn't
> > > > referenced in the Android APIs.  This is outside our scope, and we
> > > > really can't do anything more with this without even more breakage.
> > > >
> > > > On Thu, Nov 14, 2013 at 8:26 AM, Mike Billau <mike.billau@gmail.com>
> > > > wrote:
> > > > > Hi everyone,
> > > > >
> > > > > This ticket[1] came in pretty recently talking about how input
> > > type=file
> > > > > does not work with Android 4.4 anymore, regardless of what your
> > target
> > > > SDK
> > > > > is.
> > > > >
> > > > > Apparently this was a conscious design decision by Android [2].
> > > > >
> > > > > Does anybody have ideas on how we can fix this? Is this even in our
> > > > scope?
> > > > > From what I can gather, we have always had to override certain
> > 'hidden'
> > > > > (yet public) methods on CordovaChromeClient [3] to enable input
> > > > type=file.
> > > > > I'm thinking that either Android made this a private method or they
> > > just
> > > > > changed the method signature again. If they just changed the method
> > > > > signature, hopefully the new one will surface pretty soon and we
> can
> > > > adjust
> > > > > CordovaChromeClient (I tried looking around in Android source but
> got
> > > > > pretty lost pretty quick...)
> > > > >
> > > > > Just wanted to get some more opinions on what we should do. This
> > seems
> > > > like
> > > > > it could be a pretty breaking change for some of our users.
> > > > >
> > > > >
> > > > > [1] https://issues.apache.org/jira/browse/CB-5294
> > > > > [2] http://code.google.com/p/android/issues/detail?id=62220
> > > > > [3]
> > > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaChromeClient.java#L367
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message