cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian LeRoux...@brian.io>
Subject Re: File API tests
Date Thu, 07 Nov 2013 15:41:54 GMT
Nice =)


On Tue, Nov 5, 2013 at 8:51 PM, Ian Clelland <iclelland@chromium.org> wrote:

> On Mon, Nov 4, 2013 at 1:47 PM, Michal Mocny <mmocny@chromium.org> wrote:
>
> > Easier to read and catching errors that had gone undetected for a long
> > time?
> >
> > Sounds like a ringing endorsement to me ;)
> >
>
> Oh -- and smaller, too :)
>
> The test suite dropped 1300 lines -- from 3831 lines to 2550 (-33%)
>
> Definitely a win.
>
>
> >
> > On Mon, Nov 4, 2013 at 2:34 PM, Ian Clelland <iclelland@google.com>
> wrote:
> >
> > > So I've *just* completed rewriting all 105 File API tests to the new
> > > (Jasmine 2) style. They're much more readable, and hopefully more
> > > maintainable now.
> > >
> > > You can follow along on the cdvtest branch of cordova-file-plugin, if
> > > you're using Michal's new test framework.
> > >
> > > There are 2 failing tests, which actually failed undetected previously.
> > > I'll see if I can push a fix for those two later today.
> > >
> > > Ian
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message