cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Grebnov (Akvelon)" <v-seg...@microsoft.com>
Subject RE: Version and Id is not set correctly in Windows 8 package.appxmanifest
Date Mon, 18 Nov 2013 08:27:56 GMT
Hi Maxime,

#1 Version issue is duplicate of https://issues.apache.org/jira/browse/CB-5337
https://github.com/apache/cordova-cli/pull/76 
https://github.com/sgrebnov/cordova-cli/commit/91eeb217169bffcaaff8957c20b273ec51363b85

PS. Thx for the fixes and your contribution to Windows platform

Thx!
Sergey
-----Original Message-----
From: Maxime LUCE [mailto:Maxime@somatic.fr] 
Sent: Friday, November 15, 2013 8:35 PM
To: dev@cordova.apache.org
Subject: Version and Id is not set correctly in Windows 8 package.appxmanifest

Hi,


When using CLI with Windows 8 Platform :

1. Cordova default version string is not compatible with Windows 8 one (0.0.0 vs 0.0.0.0)
so add a .0 automatically.

2. In package.appxmanifest, Application.id must be a safe name, which is not actually, we
can use packageName (which is safe) or compute a safe name based on config name.


I created an issue on JIRA : https://issues.apache.org/jira/browse/CB-5400
I also created a Pull Request : https://github.com/apache/cordova-cli/pull/93

PR resolves version and id issue, it also set the identity.name of the package to ensure it's
unique.
Moreover it append an author field to config_parser and use it to ensure publisher name is
set correctly.


Cordialement.
----------------------------
Maxime LUCE
maxime@touchit.fr
06 28 60 72 34
http://touchit.fr



Mime
View raw message