cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Gill" <stevengil...@gmail.com>
Subject Re: Review Request 15891: Don't require JAVA_HOME to be defined
Date Wed, 27 Nov 2013 22:25:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15891/#review29521
-----------------------------------------------------------

Ship it!


Ship It!

- Steven Gill


On Nov. 27, 2013, 10:08 p.m., Mark Koudritsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15891/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2013, 10:08 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-5422
>     https://issues.apache.org/jira/browse/CB-5422
> 
> 
> Repository: cordova-android-git
> 
> 
> Description
> -------
> 
> JAVA_HOME is not necessarily defined on Linux and Mac. Print out the value of JAVA_HOME
in the error message in case "java -version" fails.
> 
> 
> Diffs
> -----
> 
>   bin/lib/check_reqs.js 0697f77 
> 
> Diff: https://reviews.apache.org/r/15891/diff/
> 
> 
> Testing
> -------
> 
> cordova create
> cordova platform add android (with and without accessible java).
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message