cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Koudritsky" <kam...@gmail.com>
Subject Re: Review Request 15046: "Prepare" should not depend on the ~/.cordova/libs directory
Date Thu, 07 Nov 2013 21:09:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15046/
-----------------------------------------------------------

(Updated Nov. 7, 2013, 9:09 p.m.)


Review request for cordova.


Changes
-------

Missed something in the previous attempt with rebase and conflict resolution. This patch should
apply ok.


Bugs: CB-5063
    https://issues.apache.org/jira/browse/CB-5063


Repository: cordova-cli


Description
-------

Currently all platform parsers (src/metadata/*_parser.js) copy
cordova.js from util.libDirectory for each run of prepare. This results
in errors when changing machines since the ~/.cordova/lib directory is
not populated.

With this change all the parsers construct the project www dir by first
copying contents of a new dir named <project_root>/platforms/<platfrom>/platform_www
(which contains cordova.js) and then the www dir from the app.

Until individual platform create scripts will be updated to create the
platform_www dir, prepare.js checks if the platform_www exists and if
not, creates it using cordova.js from ~/.cordova/lib.

Even after the platform create scripts are updated the check will be
required for projects that were created using older version and don't
yet have a platform_www dir.


Diffs (updated)
-----

  spec/build.spec.js 6e30825 
  spec/compile.spec.js 5b4682a 
  spec/emulate.spec.js ddc5a21 
  spec/info.spec.js e281829 
  spec/platform.spec.js e6925a2 
  spec/plugin.spec.js 1f4bf97 
  spec/prepare.spec.js 8012924 
  spec/run.spec.js 0a85fcb 
  src/build.js 440817c 
  src/compile.js a9a31e8 
  src/emulate.js cf5e7b9 
  src/info.js b64c58e 
  src/platform.js 8800bc1 
  src/plugin.js 0139393 
  src/prepare.js 4ea22c5 
  src/run.js 13dcb11 
  src/serve.js 0e4a475 
  src/util.js 07189df 

Diff: https://reviews.apache.org/r/15046/diff/


Testing
-------

npm test
corodva platform add android
corodva platform add ios
corodva platform add balckberry10
cordova prepare
verified platfrom_www dir exists and contains the right file.

Did not test for win platforms.


Thanks,

Mark Koudritsky


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message