Return-Path: 
 <dev-return-27399-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 24C2710CD2
	for <apmail-cordova-dev-archive@www.apache.org>;
 Tue, 22 Oct 2013 00:11:51 +0000 (UTC)
Received: (qmail 45970 invoked by uid 500); 22 Oct 2013 00:11:50 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 45950 invoked by uid 500); 22 Oct 2013 00:11:50 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 45942 invoked by uid 99); 22 Oct 2013 00:11:50 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Oct 2013 00:11:50 +0000
X-ASF-Spam-Status: No, hits=1.5 required=5.0
	tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of shazron@gmail.com designates
 209.85.216.179 as permitted sender)
Received: from [209.85.216.179] (HELO mail-qc0-f179.google.com)
 (209.85.216.179)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Oct 2013 00:11:45 +0000
Received: by mail-qc0-f179.google.com with SMTP id k18so2777023qcv.38
        for <dev@cordova.apache.org>; Mon, 21 Oct 2013 17:11:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        bh=FjExvrfA1t12aZgZonlgWQO1qQ71bst1NEDXGuIsOBE=;
        b=qGLaDuADuFME2hh4CoBjRyQiGf/UvCr0sfkMhvaBAEeDBZHNfHXJU1TKQF1IZXWstj
         jczLWwM8h7YIMvFYmZJmJUU85HVKpg6NbGwUcavrp0bTl3+97DMNyIbrovA+usrbDmVr
         NVZBXyejmVb+sZOSIJI441T3PAu5E9PpUlxhgljtxNquJmdOe2ckcE+/BJ+hREz/hzYJ
         hZgHuBgnH2B6xMorAlOO08JYO58PP0IcSwduBj7V4AIKEs3ylIk2rpYBzMmQHqq7DfY5
         cfddXnpukNl/4ce/veDyKNX5BmDtYQqKuR6AyL3yeo5m5iYhmcvpPAsCr2kE48ym9Oky
         m8LQ==
X-Received: by 10.229.87.1 with SMTP id u1mr10283955qcl.22.1382400684449; Mon,
 21 Oct 2013 17:11:24 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.49.41.8 with HTTP; Mon, 21 Oct 2013 17:10:44 -0700 (PDT)
In-Reply-To: 
 <CABiQX1UhZvkBzJXM_ajvy5wv0gW4rz52vS5xt-YaEtaRkGneJg@mail.gmail.com>
References: 
 <CABiQX1UhZvkBzJXM_ajvy5wv0gW4rz52vS5xt-YaEtaRkGneJg@mail.gmail.com>
From: Shazron <shazron@gmail.com>
Date: Mon, 21 Oct 2013 17:10:44 -0700
Message-ID: 
 <CAE6O_-a6k0to_BQkBrFAF44mHEB+L6APoqGQvVP=wkdAUBZKXw@mail.gmail.com>
Subject: Re: Code review of new ios plugins
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Cc: Shazron Abdullah <shaz@adobe.com>
Content-Type: multipart/alternative; boundary=001a11340c10bbe99504e9493da1
X-Virus-Checked: Checked by ClamAV on apache.org

--001a11340c10bbe99504e9493da1
Content-Type: text/plain; charset=ISO-8859-1

Answers inline.


Looking at the Keyboard & Statusbar plugins, would you be opposed to using:
>
> <clobbers target="cordova.plugins.statusBar" />
>
> instead of:
>
> <clobbers target="window.StatusBar" />
>
>

Agreed.


> Would require a major version bump, but probably it has little usage since
> it's new & in labs still?
>
>
Agreed, major version bump.


> Thinking here is that since it's not implementing any spec, we should keep
> symbols off of window / navigator objects. Would be good to encourage
> plugins not to pollute the global namespace I think.
>
>
Agreed.


> Other points from code-review standpoint:
> - Why make StatusBar a function? It has no prototype methods.
>

Originally it had prototype methods, but I changed that - yup we can remove
that.


> - You're calling exec() from the module scope. You should add a <runs/> to
> the <js-module> to ensure it gets run at start-up. You should also delay
> deviceready until it executes. cordova-plugin-device has an example of
> this.
>

Great - wasn't too sure about how that all worked, let's change that.


> - Might be nicer to make the status-bar state a callback with
> keepCallback=true so that the native code is agnostic to where the
> namespace is mapped.
>

Agreed.

Thanks Andrew! I'll add an issue for this.

--001a11340c10bbe99504e9493da1--