Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A595B10D34 for ; Fri, 18 Oct 2013 05:09:07 +0000 (UTC) Received: (qmail 64677 invoked by uid 500); 18 Oct 2013 05:09:03 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 64642 invoked by uid 500); 18 Oct 2013 05:09:00 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 64628 invoked by uid 99); 18 Oct 2013 05:08:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Oct 2013 05:08:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 08B191D360E; Fri, 18 Oct 2013 05:08:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3327632726732694225==" MIME-Version: 1.0 Subject: Re: Review Request 12472: Convert our site to use Jekyll instead of mustache + add a blog From: "Carlos Santana" To: "Carlos Santana" , "Michael Brooks" Cc: "Andrew Grieve" , "cordova" Date: Fri, 18 Oct 2013 05:08:58 -0000 Message-ID: <20131018050858.7314.83756@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Carlos Santana" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/12472/ X-Sender: "Carlos Santana" References: <20130711215253.14335.82299@reviews.apache.org> In-Reply-To: <20130711215253.14335.82299@reviews.apache.org> Reply-To: "Carlos Santana" --===============3327632726732694225== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12472/#review27176 ----------------------------------------------------------- close this review, its resolved - Carlos Santana On July 11, 2013, 9:52 p.m., Andrew Grieve wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12472/ > ----------------------------------------------------------- > > (Updated July 11, 2013, 9:52 p.m.) > > > Review request for cordova, Carlos Santana and Michael Brooks. > > > Bugs: CB-3997 > https://issues.apache.org/jira/browse/CB-3997 > > > Repository: cordova-site > > > Description > ------- > > Convert our site to use Jekyll instead of mustache. > - Adds a blog section with a first post. > - Adds a favicon > - Tweaks Rakefile & friends > > This is a combination of Carlos' and my changes. > > Changes since the version on https://github.com/csantanapr/cordova-blog > - Change the first blog post to be much shorter so that it's entirely uncontroversial. > - Added docs/, wiki-images, etc. to the keep_files setting > - Set the basepath within _config.yml and removed it from scripts. This prevents paths from being different depending on running rake serve vs rake build. > - Tweaked README.md to say that some files are in public/ while others are in www/ > - Restored search box script that was accidentally removed > - Fixed an unclosed div on the main page (that I messed up in my pull request to Carlos) > > > Diffs > ----- > > /Gemfile 1502264 > /README.md 1502264 > /Rakefile 1502264 > /_config.yml PRE-CREATION > /bin/gen.rb 1501850 > /bin/serve.rb PRE-CREATION > /public/artwork.html 1502289 > /public/blog/2013/07/11/cordova-has-a-blog.html PRE-CREATION > /public/blog/index.html PRE-CREATION > /public/css/main.css PRE-CREATION > /public/css/master.css PRE-CREATION > /public/css/syntax.css PRE-CREATION > /public/index.html 1502289 > /public/master.css 1502264 > /public/rss.xml PRE-CREATION > /www/_includes/footer.html PRE-CREATION > /www/_includes/head.html PRE-CREATION > /www/_includes/header.html PRE-CREATION > /www/_includes/links.html PRE-CREATION > /www/_layouts/cordova.html PRE-CREATION > /www/_layouts/default.html PRE-CREATION > /www/_layouts/post.html PRE-CREATION > /www/_posts/2013-07-08-cordova-has-a-blog.md PRE-CREATION > /www/artwork.html 1502294 > /www/blog/index.html PRE-CREATION > /www/css/_master.less PRE-CREATION > /www/css/main.css PRE-CREATION > /www/css/syntax.css PRE-CREATION > /www/docs/README.md 1502264 > /www/downloads/BlueZedEx.mp3 UNKNOWN > /www/downloads/icons_3.zip UNKNOWN > /www/downloads/logos_2.zip UNKNOWN > /www/downloads/screens_3.zip UNKNOWN > /www/images/cordova_128.png UNKNOWN > /www/images/cordova_16.png UNKNOWN > /www/images/cordova_24.png UNKNOWN > /www/images/cordova_256.png UNKNOWN > /www/images/cordova_32.png UNKNOWN > /www/images/cordova_48.png UNKNOWN > /www/images/cordova_512.png UNKNOWN > /www/images/cordova_64.png UNKNOWN > /www/images/cordova_bot.jpg UNKNOWN > /www/images/cordova_bot.png UNKNOWN > /www/images/grid.png UNKNOWN > /www/images/logo_full.png UNKNOWN > /www/images/shadow.png UNKNOWN > /www/images/splash.png UNKNOWN > /www/images/sprite.png UNKNOWN > /www/index.html PRE-CREATION > /www/js/less-1.1.5.min.js 1502264 > /www/master.less 1502264 > /www/rss.xml PRE-CREATION > /www/template.html 1502264 > > Diff: https://reviews.apache.org/r/12472/diff/ > > > Testing > ------- > > Ensured that when you type "rake build", that "svn status" reports no changes. > > I also tried to manually compare the site to the existing one and tested most links. > > > Thanks, > > Andrew Grieve > > --===============3327632726732694225==--