Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7167910410 for ; Sat, 12 Oct 2013 02:46:23 +0000 (UTC) Received: (qmail 98512 invoked by uid 500); 12 Oct 2013 02:46:10 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 98476 invoked by uid 500); 12 Oct 2013 02:46:08 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 98421 invoked by uid 99); 12 Oct 2013 02:45:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Oct 2013 02:45:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0E5421D34F0; Sat, 12 Oct 2013 02:45:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8874978995544488627==" MIME-Version: 1.0 Subject: Review Request 14621: Fix plugin JS installation during cordova prepare From: "Ian Clelland" To: "Jeffrey Heifetz" Cc: "Ian Clelland" , "cordova" Date: Sat, 12 Oct 2013 02:45:56 -0000 Message-ID: <20131012024556.29481.27237@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ian Clelland" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/14621/ X-Sender: "Ian Clelland" Reply-To: "Ian Clelland" --===============8874978995544488627== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14621/ ----------------------------------------------------------- Review request for cordova and Jeffrey Heifetz. Bugs: CB-4774 https://issues.apache.org/jira/browse/CB-4774 Repository: cordova-cli Description ------- Changes order of operations in `cordova prepare` so that the app www directory is clobbered before plugins are prepared. Without this, the platforms' www directories do not have end up with plugins installed after a `cordova prepare` execution. Diffs ----- src/metadata/android_parser.js 2df37e6 src/metadata/blackberry10_parser.js 5ad4f0b src/metadata/firefoxos_parser.js 51f6e1a src/metadata/ios_parser.js 15854e8 src/metadata/wp7_parser.js 5bda771 src/metadata/wp8_parser.js ad914b6 src/prepare.js 62dbf65 Diff: https://reviews.apache.org/r/14621/diff/ Testing ------- Created new mobile spec project: cordova-cli/bin/cordova create mobilespec com.example.mobilespec mobilespec cd mobilespec ../cordova-cli/bin/cordova platform add android ../cordova-cli/bin/cordova platform add ios ../cordova-cli/bin/cordova plugin add ../cordova-mobile-spec/dependencies-plugin rm -r www ln -s ../cordova-mobile-spec/ www ../cordova-cli/bin/cordova prepare Checked for existence of platforms/android/assets/www/plugins and platforms/ios/www/plugins. Ran mobile spec tests on android and ios to verify that plugins were loading correctly. Other platform parsers are changed to match ios and android, but I don't have hardware to verify the changes. Thanks, Ian Clelland --===============8874978995544488627==--