Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5C1CA10A3F for ; Wed, 2 Oct 2013 18:01:20 +0000 (UTC) Received: (qmail 29520 invoked by uid 500); 2 Oct 2013 18:01:20 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 29496 invoked by uid 500); 2 Oct 2013 18:01:20 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 29483 invoked by uid 99); 2 Oct 2013 18:01:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Oct 2013 18:01:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7259C1D3402; Wed, 2 Oct 2013 18:01:18 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8773899413516303417==" MIME-Version: 1.0 Subject: Re: Review Request 14446: [CB-4749]: Display proper error if cordova prepare run not in project dir. From: "Michal Mocny" To: "Mark Koudritsky" , "Michal Mocny" , "cordova" Date: Wed, 02 Oct 2013 18:01:18 -0000 Message-ID: <20131002180118.22177.1346@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Michal Mocny" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/14446/ X-Sender: "Michal Mocny" References: <20131002175426.28588.6415@reviews.apache.org> In-Reply-To: <20131002175426.28588.6415@reviews.apache.org> Reply-To: "Michal Mocny" --===============8773899413516303417== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14446/#review26613 ----------------------------------------------------------- Ship it! Ship It! - Michal Mocny On Oct. 2, 2013, 5:54 p.m., Mark Koudritsky wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14446/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 5:54 p.m.) > > > Review request for cordova. > > > Bugs: CB-4749 > https://issues.apache.org/jira/browse/CB-4749 > > > Repository: cordova-cli > > > Description > ------- > > [CB-4749]: Display proper error if cordova prepare run not in project dir. > > cordova prepare fails with a cryptic error message if run not from > cordova project dir: > TypeError: Arguments to path.join must be strings > Fixed it to display the usual: > Error: Current working directory is not a Cordova-based project. > > > Diffs > ----- > > src/util.js 83c3284b8dbcbbfb3c2719604598ed8d7dbf8bbe > > Diff: https://reviews.apache.org/r/14446/diff/ > > > Testing > ------- > > > Thanks, > > Mark Koudritsky > > --===============8773899413516303417==--