cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dick Van den Brink <d_vandenbr...@outlook.com>
Subject RE: Cordova CLI pre_package hook
Date Mon, 07 Oct 2013 17:21:03 GMT
Updated the changes. My CLA is already in the Apache Foundation records since last week.
Thanks for the feedback.
 
 
> Date: Mon, 7 Oct 2013 11:03:47 -0400
> Subject: Re: Cordova CLI pre_package hook
> From: braden@chromium.org
> To: dev@cordova.apache.org
> 
> I've added some comments. Ping this thread when you have a CLA on file and
> have made those changes, and I'll pull this change.
> 
> Braden
> 
> 
> On Mon, Oct 7, 2013 at 10:17 AM, Dick Van den Brink <
> d_vandenbrink@outlook.com> wrote:
> 
> > Hi guys,
> >
> >
> > I noticed that only the WP7 parser fired a hook (with the
> > name "pre_package") on the cordova-cli master branch when updating a
> > project, this hook is missing in the WP8
> > parser so I added this hook.
> >
> >
> > I also noticed that the hook on the WP7 parser didn't work
> > correctly because the hook is fired asynchronous. I patched this in the WP7
> > project.
> >
> >
> > I already signed the CLA so I was hoping someone could take
> > a look at my pull request! Any feedback is appreciated.
> >
> > https://github.com/apache/cordova-cli/pull/43
> > This is my first patch for Cordova so I'm not really sure what the
> > workflow is, should I create a issue on Jira first? I hope to write some
> > more patches, mainly for Windows Phone, Android and maybe Windows 8. Thanks
> > for reading :)
> >
> >
> > Best regards,
> >
> > Dick van den
> > Brink
 		 	   		  
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message