cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Santana <csantan...@gmail.com>
Subject Re: reviewboard .reviewboardrc and TRACKING_BRANCH = 'origin/dev' ?
Date Wed, 16 Oct 2013 06:41:07 GMT
Wiki has being updated
https://wiki.apache.org/cordova/CommitterWorkflow

list which repos can be use with post-review, and using github as
alternative for code review.

Oh and I manage to get Jesse's cell number so its there also :-)

--Carlos


On Wed, Oct 16, 2013 at 1:56 AM, Carlos Santana <csantana23@gmail.com>wrote:

> 1. How do I use post-review on cordova-wp8 repo then? without
> .reviewboardrc it doesn't work
>
> cordova-wp8:(master)$ post-review
> Unable to find a Review Board server for this source code tree.
>
> 2. I agree 100% (lets kill dev branch)
> But today How do I use post-review to submit a review for a commit that I
> want to push to dev branch for plugin?
>
> 3. what's your phone number? :-)
>
> I'm serious here if this post-review piece of sh%$ doesn't work I don't
> want to use it then. Or maybe don't send any code review since I have write
> access to repo now.
>
> Maybe this makes my question more clear now.
>
>
>
> On Wed, Oct 16, 2013 at 1:42 AM, Jesse <purplecabbage@gmail.com> wrote:
>
>> My thoughts:
>>
>> 1. No,
>> 2. master SHOULD be used for development, and considered unstable, but
>> probably should have passing tests.
>>     - this is not currently the case, but we need to change this. plugman,
>> I believe is still pulling from master where it should be pulling from a
>> version tag
>> 3. use github, use this mailing list, use a phonecall, ...
>>
>>
>> @purplecabbage
>> risingj.com
>>
>>
>> On Tue, Oct 15, 2013 at 10:13 PM, Carlos Santana <csantana23@gmail.com
>> >wrote:
>>
>> > 1. Should all repos contain a file ".reviewboardrc" ? Some repos are
>> > missing this file
>> >
>> > 2. Should the plugins repos contain the file ".reviewboardrc" and it
>> should
>> > have a variable TRACKING_BRANCH = 'origin/dev'? since 'master' is not
>> being
>> > use for development.
>> >
>> > 3. Is obligatory to only use reviewboard? or can committers use github
>> to
>> > review code?
>> > 3a. As a personal preference I like github better for reviews, search,
>> and
>> > share code reviews. Maybe because it's what I have used for some time
>> as a
>> > contributor and also on other open source projects I contribute I also
>> use
>> > github for reviews/pullrequests
>> >
>> >
>> > References:
>> >
>> >
>> >
>> https://github.com/reviewboard/rbtools/blob/master/docs/rbtools/post-review.txt
>> >
>> >
>> > --
>> > Carlos Santana
>> > <csantana23@gmail.com>
>> >
>>
>
>
>
> --
> Carlos Santana
> <csantana23@gmail.com>
>



-- 
Carlos Santana
<csantana23@gmail.com>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message