cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: PSA: watch for stipped [CB-####] from patch subject line when using git am
Date Wed, 02 Oct 2013 19:02:54 GMT
Removing brackets sounds good to me!


On Wed, Oct 2, 2013 at 11:56 AM, Michal Mocny <mmocny@chromium.org> wrote:

> Shoot, yes, I had to manually edit the message and somehow copied from the
> wrong JIRA issue.  Sorry!  Not worth changing history over, but yes, my
> bad.
>
> +1 to changing convention to not include [], great low road solution.
>
> On Wed, Oct 2, 2013 at 2:38 PM, Jeffrey Heifetz <jheifetz@blackberry.com
> >wrote:
>
> > Is that the reason that commit that was just pushed had the wrong issue
> # ?
> >
> > On 13-10-02 2:35 PM, "Michal Mocny" <mmocny@google.com> wrote:
> >
> > >As I just discovered, git has a bug where it will strip the leading
> > >[CB-####] when using "git am" to apply a patch made with git
> format-patch.
> > > Details here: [1].
> > >
> > >You can apparently use -k in both the commands to resolve the issue, but
> > >since that isn't possible with github pull requests (they offer the non
> -k
> > >version of format-patch), I say we just stick to watching for the issue
> > >manually.
> > >
> > >Not a big deal, but worth noting.
> > >
> > >[1]:
> > >
> >
> http://ubuntu.5.x6.nabble.com/maintainer-tip-git-format-patch-k-git-am-k-t
> > >d5028045.html
> >
> > ---------------------------------------------------------------------
> > This transmission (including any attachments) may contain confidential
> > information, privileged material (including material protected by the
> > solicitor-client or other applicable privileges), or constitute
> non-public
> > information. Any use of this information by anyone other than the
> intended
> > recipient is prohibited. If you have received this transmission in error,
> > please immediately reply to the sender and delete this information from
> > your system. Use, dissemination, distribution, or reproduction of this
> > transmission by unintended recipients is not authorized and may be
> unlawful.
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message