cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: PSA: watch for stipped [CB-####] from patch subject line when using git am
Date Wed, 02 Oct 2013 18:48:06 GMT
The example on the linked page seems to indicate that it looks for bug IDs
(brackets or not)


On Wed, Oct 2, 2013 at 7:45 PM, Marcel Kinard <cmarcelk@gmail.com> wrote:

> It's that bracket-wrapping that drives the automatic comment insertion in
> the Jira item upon a git commit-push.
> http://www.apache.org/dev/svngit2jira.html
>
> On Oct 2, 2013, at 2:40 PM, Andrew Grieve <agrieve@chromium.org> wrote:
>
> > Crazy. Maybe we should just change our convention to not add []s around
> the
> > bug IDs?
> >
> >
> > On Wed, Oct 2, 2013 at 7:35 PM, Michal Mocny <mmocny@google.com> wrote:
> >
> >> As I just discovered, git has a bug where it will strip the leading
> >> [CB-####] when using "git am" to apply a patch made with git
> format-patch.
> >> Details here: [1].
> >>
> >> You can apparently use -k in both the commands to resolve the issue, but
> >> since that isn't possible with github pull requests (they offer the non
> -k
> >> version of format-patch), I say we just stick to watching for the issue
> >> manually.
> >>
> >> Not a big deal, but worth noting.
> >>
> >> [1]:
> >>
> >>
> http://ubuntu.5.x6.nabble.com/maintainer-tip-git-format-patch-k-git-am-k-td5028045.html
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message