cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: PSA: watch for stipped [CB-####] from patch subject line when using git am
Date Thu, 03 Oct 2013 01:35:19 GMT
That applies to cordova-js only, and I think it's a nice-to-have. If it's
left out, it just means I need to open the diff to see what's changed. If
it's there though, I don't need to.


On Wed, Oct 2, 2013 at 10:47 PM, Marcel Kinard <cmarcelk@gmail.com> wrote:

> ContributorWorkflow and CommitterWorkflow wiki pages updated.
>
> I noticed the following verbage in CommitterWorkflow:
>
>         • Prefix the message with the affected_platform so that it's clear
> who should take interest in the commit
>         • e.g.: CB-1234 android: Improved exec bridge by using strings
> instead of JSON
>         • e.g.: CB-1234 all: Fixed plugin loading paths that start with /.
>
> Should that verbage stay in? I don't think we do that consistently.
>
> On Oct 2, 2013, at 3:29 PM, Andrew Grieve <agrieve@chromium.org> wrote:
>
> > +1
> >
> >
> > On Wed, Oct 2, 2013 at 8:17 PM, Marcel Kinard <cmarcelk@gmail.com>
> wrote:
> >
> >> So new format should be:
> >>
> >> CB-1234 Fixed the RockOn widget
> >>
> >> Correct?
> >>
> >>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message