cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Code review of new ios plugins
Date Mon, 21 Oct 2013 20:35:42 GMT
Hey Shaz,

Looking at the Keyboard & Statusbar plugins, would you be opposed to using:

<clobbers target="cordova.plugins.statusBar" />

instead of:

<clobbers target="window.StatusBar" />

Would require a major version bump, but probably it has little usage since
it's new & in labs still?

Thinking here is that since it's not implementing any spec, we should keep
symbols off of window / navigator objects. Would be good to encourage
plugins not to pollute the global namespace I think.

Other points from code-review standpoint:
- Why make StatusBar a function? It has no prototype methods.
- You're calling exec() from the module scope. You should add a <runs/> to
the <js-module> to ensure it gets run at start-up. You should also delay
deviceready until it executes. cordova-plugin-device has an example of
this.
- Might be nicer to make the status-bar state a callback with
keepCallback=true so that the native code is agnostic to where the
namespace is mapped.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message