cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <purplecabb...@gmail.com>
Subject Re: CLI and Plugman test failures
Date Thu, 17 Oct 2013 17:55:52 GMT
Yeah the windows8 tests were in a branch without promises, and did not exist for you to vigorously
patch. 

Sent from my iPhone

> On Oct 17, 2013, at 10:48 AM, Braden Shepherdson <braden@chromium.org> wrote:
> 
> I fixed all the tests vigorously when I was making that refactoring. If
> people have been adding lazy[1] tests similar to the ones I was fixing,
> then they're not going to work.
> 
> [1] By "lazy tests", I mean tests that are really testing async functions,
> but only mocking things that are called immediately, so they pretend the
> call is synchronous. Most of those were broken by the refactoring.
> 
> Since jasmine-node supports the 'done' argument, it's pretty easy to put
> your expectations into a .then() and then call done().
> 
> Braden
> 
> 
> On Thu, Oct 17, 2013 at 1:44 PM, purplecabbage <purplecabbage@gmail.com>wrote:
> 
>> I believe the failures are the result of promise additions. Some 'expects'
>> will have to wait.
>> 
>> The error I kept seeing is an attempt to shell.rm
>> 
>> Sent from my iPhone
>> 
>>>> On Oct 17, 2013, at 10:21 AM, Steven Gill <stevengill97@gmail.com>
>>> wrote:
>>> 
>>> I actually created an issue about cleaning up the tests yesterday
>> evening.
>>> https://issues.apache.org/jira/browse/CB-5106
>>> 
>>> I am planning on spending some time today and trying to get those
>> failures
>>> fixed. I also need to add some new tests.
>>> 
>>> 
>>> 
>>> 
>>> On Thu, Oct 17, 2013 at 10:17 AM, Braden Shepherdson <
>> braden@chromium.org>wrote:
>>> 
>>>> They might be related to an error, they might not. Either way, they're a
>>>> bug that needs fixing because they're not supposed to be in the output.
>>>> Similarly for the handful of JSON blurbs inside the dots at the top.
>>>> 
>>>> Braden
>>>> 
>>>> 
>>>> On Thu, Oct 17, 2013 at 12:44 PM, Ian Clelland <iclelland@chromium.org
>>>>> wrote:
>>>> 
>>>>> Are the repeated
>>>>> 
>>>>> cp: no such file or directory: /some/path/www/config.xml
>>>>> lines an expected part of the output? I saw them when I committed my
>> last
>>>>> changes, and so I checked out a couple of commits behind master and saw
>>>>> that they still appeared. I committed my changes, figuring that at
>> least
>>>> I
>>>>> hadn't *introduced* any new error output, but I'm still not certain
>>>> whether
>>>>> those lines represent an actual error, or if they're just a side-effect
>>>> of
>>>>> running the tests.
>>>>> 
>>>>> Ian
>> 

Mime
View raw message