cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bryan Higgins" <br...@bryanhiggins.net>
Subject Re: Review Request 14909: CB:5187 on node windows broken compile, emulate, run
Date Thu, 24 Oct 2013 18:14:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14909/#review27469
-----------------------------------------------------------

Ship it!


Looks good Carlos! The commented out BB stuff can be deleted.

- Bryan Higgins


On Oct. 24, 2013, 5:37 p.m., Carlos Santana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14909/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2013, 5:37 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Repository: cordova-cli
> 
> 
> Description
> -------
> 
> CB:5187 on node  windows broken compile, emulate, run
> 
> 
> Diffs
> -----
> 
>   spec/compile.spec.js 4b9ee43104ce2ce7449ac5934c3165851285eaaa 
>   spec/emulate.spec.js 8f3303e73fe73738a7eb99c0c9be61507353a2f3 
>   spec/run.spec.js 65e6bbe87f05c6f3b84245a316da68eec88be801 
>   src/compile.js 97f7f2178d109e9112bcc2804cfacdb95fb84ddf 
>   src/emulate.js f1853a7b50ea5f7c2e175549a73453eef0120bfc 
>   src/run.js d5487b3758a00e8dba4da2c21dc46e13bf28f973 
> 
> Diff: https://reviews.apache.org/r/14909/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carlos Santana
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message