cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Gill" <stevengil...@gmail.com>
Subject Re: Review Request 14793: CB-5125: replace child process exec with spawn
Date Tue, 22 Oct 2013 22:55:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14793/#review27343
-----------------------------------------------------------

Ship it!


Looks great to me!

- Steven Gill


On Oct. 21, 2013, 6:49 p.m., Carlos Santana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14793/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 6:49 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Repository: cordova-cli
> 
> 
> Description
> -------
> 
> CB-5125: replace child process exec with spawn
> 
> This avoid stdout from platform scripts kill exec process because goes over maxBuffer
(~200KB)
> Also this give immediate feedback to user on the cli, any output from platform script
doesn't get buffer it gets passed to event emmiter
> 
> 
> Diffs
> -----
> 
>   src/compile.js 34c24fe8e66d477d74728e018c250cf5e267c351 
>   src/emulate.js cd4c038a3c2125224d25715a3fc2cf3b9e9f3cb0 
>   src/run.js dddc1fc6f7a168267decdb3f6d8c4471d3480893 
> 
> Diff: https://reviews.apache.org/r/14793/diff/
> 
> 
> Testing
> -------
> 
> Tested Android, iOS (mac osx)
> node 0.10.18
> 
> 
> Thanks,
> 
> Carlos Santana
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message