cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Gill" <stevengil...@gmail.com>
Subject Re: Review Request 14822: CB-5125 add tests for chil process spawn
Date Tue, 22 Oct 2013 22:55:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14822/#review27342
-----------------------------------------------------------

Ship it!


Looks good!

- Steven Gill


On Oct. 22, 2013, 3:16 a.m., Carlos Santana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14822/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2013, 3:16 a.m.)
> 
> 
> Review request for cordova.
> 
> 
> Repository: cordova-cli
> 
> 
> Description
> -------
> 
> CB-5125 add tests for chil process spawn
> 
> 
> CB-5125: replace child process exec with spawn
> 
> 
> Diffs
> -----
> 
>   spec/compile.spec.js 3b0fe0d0e9d399b57d4d632838e0e88e8fb2f35d 
>   spec/emulate.spec.js 79b5176b145b3b1535747bbce8d6973d45abb58c 
>   spec/run.spec.js 7d13a969459581a637ba026826af11c388d5bbb7 
>   src/compile.js 34c24fe8e66d477d74728e018c250cf5e267c351 
>   src/emulate.js cd4c038a3c2125224d25715a3fc2cf3b9e9f3cb0 
>   src/run.js dddc1fc6f7a168267decdb3f6d8c4471d3480893 
> 
> Diff: https://reviews.apache.org/r/14822/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Carlos Santana
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message