cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michal Mocny" <mmo...@chromium.org>
Subject Re: Review Request 14757: Cordova Plugin Registry Blog Post
Date Mon, 21 Oct 2013 15:13:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14757/#review27246
-----------------------------------------------------------



/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53061>

    s/what plugins/which plugins/



/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53062>

    Consider merging these two lines, and imho consider the reader an app developer instead
of being abstract.
    
    "Using the Cordova CLI, you can add plugins to your workspace with a single easy command:"
    
    I wouldn't mention messy details (it badmouths the plugman flow, and sets up for a reply
to say "hey I did blah with CLI and now I have messy details, you liar")



/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53063>

    "if you dont already have one" is implied.



/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53064>

    Not sure we need to call out unpublish, but search command is interesting.  Is it prefered
to use plugman to search, or to visit plugins.cordova.io?  Is the list the same?  Maybe expand
on that.



/www/_posts/2013-10-21-cordova-registry.md
<https://reviews.apache.org/r/14757/#comment53065>

    "app developers" -> "you", "their" -> "your", imho
    
    "access" -> "use"


- Michal Mocny


On Oct. 18, 2013, 7:59 p.m., Max Woghiren wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14757/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2013, 7:59 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Repository: cordova-site
> 
> 
> Description
> -------
> 
> A blog post outlining the basics of the Cordova plugin registry.
> 
> 
> Diffs
> -----
> 
>   /README.md 1533594 
>   /www/_posts/2013-10-21-cordova-registry.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14757/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Max Woghiren
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message