cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Koudritsky" <kam...@gmail.com>
Subject Re: Review Request 14681: CB-4748: Fail quickly if dir passed to cordova create is not empty.
Date Fri, 18 Oct 2013 18:27:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14681/
-----------------------------------------------------------

(Updated Oct. 18, 2013, 6:27 p.m.)


Review request for cordova.


Changes
-------

Fixed the tests.


Bugs: CB-4748
    https://issues.apache.org/jira/browse/CB-4748


Repository: cordova-cli


Description
-------

CB-4748: Fail quickly if dir passed to cordova create is not empty.
This change also exists as: https://github.com/apache/cordova-cli/pull/55


Also add cfg parameter to create() for extra configuration which saved in .cordova/config.json
Should come together with the corresponding change in mca.js:
https://github.com/MobileChromeApps/mobile-chrome-apps/pull/25


Diffs (updated)
-----

  spec/create.spec.js e46569d 
  src/create.js 4b2b950 

Diff: https://reviews.apache.org/r/14681/diff/


Testing (updated)
-------

./mca.js create io.some.app2

$ node node_modules/jasmine-node/bin/jasmine-node spec/create.spec.js
Finished in 0.176 seconds
10 tests, 43 assertions, 0 failures

$ npm test
Finished in 43.867 seconds
354 tests, 591 assertions, 10 failures
(The failures are in wp7 windows7 and firefoxos)


Thanks,

Mark Koudritsky


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message