cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Braden Shepherdson" <bra...@chromium.org>
Subject Re: Review Request 14681: CB-4748: Fail quickly if dir passed to cordova create is not empty.
Date Thu, 17 Oct 2013 15:09:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14681/#review27124
-----------------------------------------------------------



src/create.js
<https://reviews.apache.org/r/14681/#comment52772>

    typo: porject


- Braden Shepherdson


On Oct. 16, 2013, 9:27 p.m., Mark Koudritsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14681/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 9:27 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Bugs: CB-4748
>     https://issues.apache.org/jira/browse/CB-4748
> 
> 
> Repository: cordova-cli
> 
> 
> Description
> -------
> 
> CB-4748: Fail quickly if dir passed to cordova create is not empty.
> This change also exists as: https://github.com/apache/cordova-cli/pull/55
> 
> 
> Also add cfg parameter to create() for extra configuration which saved in .cordova/config.json
> Should come together with the corresponding change in mca.js:
> https://github.com/MobileChromeApps/mobile-chrome-apps/pull/25
> 
> 
> Diffs
> -----
> 
>   src/create.js 4b2b950 
> 
> Diff: https://reviews.apache.org/r/14681/diff/
> 
> 
> Testing
> -------
> 
> ./mca.js create io.some.app2
> 
> 
> Thanks,
> 
> Mark Koudritsky
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message