cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Clelland" <iclell...@chromium.org>
Subject Review Request 14621: Fix plugin JS installation during cordova prepare
Date Sat, 12 Oct 2013 02:45:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14621/
-----------------------------------------------------------

Review request for cordova and Jeffrey Heifetz.


Bugs: CB-4774
    https://issues.apache.org/jira/browse/CB-4774


Repository: cordova-cli


Description
-------

Changes order of operations in `cordova prepare` so that the app www directory is clobbered
before plugins are prepared. Without this, the platforms' www directories do not have end
up with plugins installed after a `cordova prepare` execution.


Diffs
-----

  src/metadata/android_parser.js 2df37e6 
  src/metadata/blackberry10_parser.js 5ad4f0b 
  src/metadata/firefoxos_parser.js 51f6e1a 
  src/metadata/ios_parser.js 15854e8 
  src/metadata/wp7_parser.js 5bda771 
  src/metadata/wp8_parser.js ad914b6 
  src/prepare.js 62dbf65 

Diff: https://reviews.apache.org/r/14621/diff/


Testing
-------

Created new mobile spec project:

    cordova-cli/bin/cordova create mobilespec com.example.mobilespec mobilespec
    cd mobilespec
    ../cordova-cli/bin/cordova platform add android
    ../cordova-cli/bin/cordova platform add ios
    ../cordova-cli/bin/cordova plugin add ../cordova-mobile-spec/dependencies-plugin
    rm -r www
    ln -s ../cordova-mobile-spec/ www
    ../cordova-cli/bin/cordova prepare

Checked for existence of platforms/android/assets/www/plugins and platforms/ios/www/plugins.
Ran mobile spec tests on android and ios to verify that plugins were loading correctly.

Other platform parsers are changed to match ios and android, but I don't have hardware to
verify the changes.


Thanks,

Ian Clelland


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message