cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Koudritsky" <kam...@gmail.com>
Subject Re: Review Request 14446: [CB-4749]: Display proper error if cordova prepare run not in project dir.
Date Wed, 02 Oct 2013 17:54:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14446/
-----------------------------------------------------------

(Updated Oct. 2, 2013, 5:54 p.m.)


Review request for cordova.


Bugs: CB-4749
    https://issues.apache.org/jira/browse/CB-4749


Repository: cordova-cli


Description
-------

[CB-4749]: Display proper error if cordova prepare run not in project dir.

cordova prepare fails with a cryptic error message if run not from
cordova project dir:
  TypeError: Arguments to path.join must be strings
Fixed it to display the usual:
  Error: Current working directory is not a Cordova-based project.


Diffs
-----

  src/util.js 83c3284b8dbcbbfb3c2719604598ed8d7dbf8bbe 

Diff: https://reviews.apache.org/r/14446/diff/


Testing
-------


Thanks,

Mark Koudritsky


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message