cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey Heifetz" <jheif...@gmail.com>
Subject Re: Review Request 14376: Update cli prepare to make platform config.xml a build artifact
Date Wed, 02 Oct 2013 13:51:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14376/
-----------------------------------------------------------

(Updated Oct. 2, 2013, 1:51 p.m.)


Review request for cordova.


Changes
-------

Wrong diff was added before


Bugs: CB-4774
    https://issues.apache.org/jira/browse/CB-4774


Repository: cordova-cli


Description
-------

Updates the prepare flow to generate the platform config.xml every time by combining www/config.xml
and platforms/cordova/defaults.xml.

If defaults.xml is not present, the original file is saved there and treated as the defaults
file.


Diffs (updated)
-----

  spec/config_parser.spec.js daa0aa8 
  spec/metadata/android_parser.spec.js 71479ae 
  spec/metadata/blackberry_parser.spec.js 97d8c7d 
  spec/metadata/ios_parser.spec.js f3e57be 
  spec/metadata/wp7_parser.spec.js d7ac782 
  spec/metadata/wp8_parser.spec.js fc90d8a 
  spec/prepare.spec.js c392e75 
  src/config_parser.js b5cd95f 
  src/metadata/android_parser.js ace8275 
  src/metadata/blackberry10_parser.js 3093233 
  src/metadata/ios_parser.js b61307c 
  src/metadata/wp7_parser.js 91697e9 
  src/metadata/wp8_parser.js 8dc121b 
  src/prepare.js b6928b9 

Diff: https://reviews.apache.org/r/14376/diff/


Testing
-------

Tested and Working for BlackBerry use cases


Thanks,

Jeffrey Heifetz


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message