Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of purplecabbage@gmail.com
 designates 209.85.214.180 as permitted sender)
MIME-Version: 1.0
Date: Wed, 11 Sep 2013 15:44:18 -0700
Message-ID: 
 <CAKP6k2vfBzhxPtg=RoPd8c8bDWy_=HQhdRj=tiksOEXPFunz-g@mail.gmail.com>
Subject: window.btoa
From: Jesse <purplecabbage@gmail.com>
To: "dev@cordova.apache.org" <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=089e0149d0ae92994404e6235c6a

--089e0149d0ae92994404e6235c6a
Content-Type: text/plain; charset=ISO-8859-1

I have 2 failing tests left on wp7 due to a lack of support for window.btoa
The current FileTransfer.js implementation of getBasicAuthHeader relies on
window.btoa otherwise it does nothing.

There is no reason the conversion could not be done in native code,
presumably faster and easier, so I am wondering why someone chose to just
return null if the window did not have the method.
I also cannot easily override/clobber this method, since it is essentially
private.

(note all tests pass on wp8, which uses ie10.  wp7 is eternally ie9)

I have several options for fixing this, each with their own
strengths/weaknesses

a. polyfill window.btoa ( and atob ) using [1]
b. fix the js implementation so it will pass username:password on to
native, if it cannot pass base64 encoded data. ( this means changing the
common FileTransfer.js )
c. provide a different implementation in js for windows phone ( using a
windows phone only version of FileTransfer.js and clobbering )
d. some sort of mixture of the above, like polyfill via plugin.xml so we
can only include the polyfill in wp7

Thinking through this while writing it, I am thinking d. makes the most
sense, although it should probably be done by the File plugin, which needs
it also, and is a dependency of FileTransfer anyway.

Any other thoughts, platform specific considerations here?


[1] https://github.com/davidchambers/Base64.js/blob/master/LICENSE

@purplecabbage
risingj.com

--089e0149d0ae92994404e6235c6a--