Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C00B31092E for ; Thu, 26 Sep 2013 23:16:29 +0000 (UTC) Received: (qmail 14078 invoked by uid 500); 26 Sep 2013 23:16:29 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 14055 invoked by uid 500); 26 Sep 2013 23:16:29 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 14047 invoked by uid 99); 26 Sep 2013 23:16:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Sep 2013 23:16:29 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of purplecabbage@gmail.com designates 209.85.212.53 as permitted sender) Received: from [209.85.212.53] (HELO mail-vb0-f53.google.com) (209.85.212.53) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Sep 2013 23:16:25 +0000 Received: by mail-vb0-f53.google.com with SMTP id i3so1337995vbh.40 for ; Thu, 26 Sep 2013 16:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=lABfOVCkuOWIYm/DYDBBNCg4vikIVjPXNs29e0O1Hx8=; b=gBsx0ihmnxRcwTIHn5Jo9jMEvg2e41lvbbvZIPj/VAUCkrupngHp2ssHfL7Knyti4B phtRChLDs3y+VW/RAUkya7r7r5BkffQeQtPIT4tEbEg4rH4HiT3u7XH/gkwiVcK8DB8q cTKYiEaq6t6Pq7NNLrTKeXxi7vHM6uqT6zel0StaQmsm9Opt24MKiHJFePQF+QwKDHqv 8WdW2d8Z0XEGgknrT9MWtc6ue2mWrdp3xk6d/+fJRFoeJ5KPi7CEUHx2bsG40zgv0xyW WzBqw+jB14LFjwkBzmXcfecXwfn2nTnA7pi3AIZ1cbjeYH3fvxIVLxPN2z6asAcTPBpp tb6w== MIME-Version: 1.0 X-Received: by 10.220.42.140 with SMTP id s12mr16502vce.33.1380237364495; Thu, 26 Sep 2013 16:16:04 -0700 (PDT) Received: by 10.58.32.33 with HTTP; Thu, 26 Sep 2013 16:16:04 -0700 (PDT) In-Reply-To: References: Date: Thu, 26 Sep 2013 16:16:04 -0700 Message-ID: Subject: Re: review code CB-4934 plugin-splashscreen stays up on windows8 From: Jesse To: "dev@cordova.apache.org" Content-Type: multipart/alternative; boundary=047d7b3a7ef2d112f704e7518d2d X-Virus-Checked: Checked by ClamAV on apache.org --047d7b3a7ef2d112f704e7518d2d Content-Type: text/plain; charset=ISO-8859-1 merged, thanks @purplecabbage risingj.com On Thu, Sep 26, 2013 at 2:59 PM, Carlos Santana wrote: > Can someone review this code? > > [CB-4934] plugin-splashscreen should not show by default on Windows8 > https://issues.apache.org/jira/browse/CB-4934 > > https://github.com/apache/cordova-plugin-splashscreen/pull/5 > > > -- > Carlos Santana > > --047d7b3a7ef2d112f704e7518d2d--