Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0072A10EA0 for ; Mon, 16 Sep 2013 21:07:40 +0000 (UTC) Received: (qmail 97328 invoked by uid 500); 16 Sep 2013 21:07:39 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 97307 invoked by uid 500); 16 Sep 2013 21:07:39 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 97299 invoked by uid 99); 16 Sep 2013 21:07:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Sep 2013 21:07:39 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of mmocny@google.com designates 209.85.214.172 as permitted sender) Received: from [209.85.214.172] (HELO mail-ob0-f172.google.com) (209.85.214.172) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Sep 2013 21:07:34 +0000 Received: by mail-ob0-f172.google.com with SMTP id gq1so4477253obb.31 for ; Mon, 16 Sep 2013 14:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=H0LS+8obWrAJkNunTarzBJtZXO9BbT4EIySCnZh+Qlg=; b=deLkL0a6Oc2icRpNixpIpqTgbneWBuLrv4EGn/wBt0q9RIa0QWZXXGUb64D52tLxMc in6kEB0ce9UB8t42LE+fIEn7oX5oywdHo39a5fNwzQVpeD7qsxTlRmZ8CdL2UbRuyAEX 0vh9GsXWwFkS6t18jD73jrbHAngxK+geLxL2hyWUpg65gzoBLfLJBVnT4f28zD2/7n+k PUbXK+hvQ5UHvBGpdkAeHAUV46p+f8aBc78OQqgL7OjbVotnEKbI4ADFW6riWWtWSKIg s8xw6ZrNZ7Mu/h+b9l0QYEi9qWrERBRapEnpYMh+KRfNL/p+qC36rwNsqccL0ECrgbws NbvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=H0LS+8obWrAJkNunTarzBJtZXO9BbT4EIySCnZh+Qlg=; b=lB3Yaz5PEbIOTWrkkwRmisA5Q8Vfciy5W2ZaaBFl4AYazafUo1R8UFrB19l/Z6He6+ ns6hHGg/sxv5BIa5wynEViBgsfg42MPPNmMObJ6XXv7Oef8jMc8EwM/FzMPl2QKnaO0g UQc24QXSr+KWIWhtudKS0akUviKhI3x0zcga4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:content-type; bh=H0LS+8obWrAJkNunTarzBJtZXO9BbT4EIySCnZh+Qlg=; b=W8HF/Esqp0xzFAsPL6DSwf5sJNNOEw0t2XFP8ClI3Mqynhe5EJMIyo/atGC9xlaQu8 q9+9U93EXM9HfASzLiGKJCAeWyUzy6bWA9nJlJ4GxKRukjjF+/X5N64CpkZthCXXZAvR l6gjvy7zttZC9kXoB4G3bINM2+GG3fqoaM+EXz8EGLjsLdj/K9Heqpz0IG0O5Y9G8wgv g6mG04zdqV1jA2J26m9NclsGcIgflJxk+orz1a/WJ0EcQ5rZLZSO7WB2cpL8a25xOa7U Hj6mfbFmHguV5KWjYEWBrb9A45FFEKdFr3BYg8ewtbL6NTuOLvodDe9a+85ux98oKEjm OyEA== X-Gm-Message-State: ALoCoQm8dzURdCd7pX8prjtA7Nm7E7Nq5YCkUDfBX2I/aSI/mRY6W4iSiSFUu05t9Xy/h4c+EL07UeKRvObFt7hPuawb6Z8o8IbRkUr1aywRlL4DvoVS+X7fFYnDhNIgk7yT5dLlpiOde3JBG+xF0slQham8SrjCO835OHaNNUcvyze90SWvJEaCzVt98W5kAuGiesanJTrunrXGEdgrW/+RU4+GrXUTag== X-Received: by 10.60.97.36 with SMTP id dx4mr451013oeb.99.1379365633114; Mon, 16 Sep 2013 14:07:13 -0700 (PDT) MIME-Version: 1.0 Sender: mmocny@google.com Received: by 10.182.139.100 with HTTP; Mon, 16 Sep 2013 14:06:51 -0700 (PDT) In-Reply-To: References: From: Michal Mocny Date: Mon, 16 Sep 2013 14:06:51 -0700 X-Google-Sender-Auth: 1LcGI8a6eIRpK7aRn94miI8yyAI Message-ID: Subject: Re: config.xml as a build artifact for less suffering and easier upgrades To: dev Content-Type: multipart/alternative; boundary=089e013a2b0893d99704e6869643 X-Virus-Checked: Checked by ClamAV on apache.org --089e013a2b0893d99704e6869643 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I've emailed github about that in the past. Hopefully they can address it, since their review system is far superior for all other reasons. On Mon, Sep 16, 2013 at 1:16 PM, Andrew Grieve wrote= : > We do get emails for some pull requests, but some repos aren't set up to > email and looks like CLI is one of them. Think you need to file an INFRA > ticket to fix it :(. > > I'm liking reviewboard more than github for reviews since it lets you > review your comments without sending an email for each and every one of > them. I'm fine with using github as well though since that's what most > people tend to use. > > > On Mon, Sep 16, 2013 at 4:06 PM, Michal Mocny wrote= : > > > We don't get email notified (or, at least I don't) of github pull > requests, > > but we do get emails for review-board (or at least the assignee does?). > > Either way, if you post a link you'll likely get better luck with a > review > > quicker next time, sorry that we missed it. I can't peek until > > tomorrow/wed, so if no one gets to it, I'll do it then. > > > > -Michal > > > > On Mon, Sep 16, 2013 at 11:16 AM, Jeffrey Heifetz > > wrote: > > > > > So I believe this pull request is ready to go, however I have yet to > get > > > any feedback on the request itself. Can anyone familiar with the othe= r > > > platforms volunteer to test this with them? > > > > > > Is this a question of presentation, should I close the github pull > > request > > > in favour of the cordova review board ? > > > > > > On 13-09-12 2:13 PM, "Michal Mocny" wrote: > > > > > > >Thats awesome, looking forward to it! > > > > > > > > > > > >On Thu, Sep 12, 2013 at 10:22 AM, Jeffrey Heifetz > > > >wrote: > > > > > > > >> Yup I'm on the same page with you Michal, and I believe Braden as > > well. > > > >> I'm sorry I should have said so earlier, we resolved this on irc. = I > > > >>have a > > > >> basic implementation here > > https://github.com/apache/cordova-cli/pull/39 > > > >> but I'm still testing it. > > > >> > > > >> On 13-09-12 12:36 PM, "Michal Mocny" wrote: > > > >> > > > >> >Trying to clarify the misunderstanding... > > > >> > > > > >> >Jeffrey, if I understand your email, your understanding of point > (4) > > of > > > >> >bradens flow is that the app.xml is *being* munged, whereas we > meant > > > >>that > > > >> >its the app.xml config that is *doing* the munging to the platfor= m > > > >>config. > > > >> > I think that means we both agree that app.xml should never be > > > >>modified, > > > >> >and it was just a miscommunication. Am I right with that > > > >>understanding? > > > >> > > > > >> >Also, in your proposal you have plugins munging/preparing *after* > > > >>app.xml > > > >> >does its munging. I assume you did not do intentionally, that you > had > > > >>just > > > >> >not considered the order important. If it was intentional, why? > We > > > >>were > > > >> >thinking app.xml should be last and thus have the most > "importance". > > > >> > > > > >> > > > > >> >On Wed, Sep 11, 2013 at 11:38 AM, Braden Shepherdson > > > >> >wrote: > > > >> > > > > >> >> I think we've gotten a bit confused. Let me try to describe aga= in > > the > > > >> >>way I > > > >> >> was envisioning things. > > > >> >> > > > >> >> 1. If defaults.xml exists, replace platform config.xml with it. > > > >> >> 2. Use plugman to add each plugin's changes onto > the > > > >> >>platform > > > >> >> config.xml. > > > >> >> 3. Add in the values from the app config.xml: , > > etc., > > > >> >>which > > > >> >> it currently does, plus the proposed new tags. > > > >> >> 4. Somewhere in there, call plugman prepare to update the JS > > modules. > > > >> >>This > > > >> >> doesn't change or depend on config.xml at all. > > > >> >> > > > >> >> NB: I don't suggest anywhere that we edit the user's top-level, > app > > > >> >> config.xml. This is just a process for building the platform > > > >>config.xml, > > > >> >> and making it a pure build artifact. > > > >> >> > > > >> >> I also suggest that the "last word"; the file whose changes are > > added > > > >> >>last, > > > >> >> is the app config.xml. This allows the user the power to overri= de > > any > > > >> >> default or setting from a plugin. > > > >> >> > > > >> >> Braden > > > >> >> > > > >> >> > > > >> >> On Wed, Sep 11, 2013 at 2:16 PM, Jeffrey Heifetz > > > >> >> > > >> >> >wrote: > > > >> >> > > > >> >> > I'd like to clarify the changes to prepare before I continue > the > > > >> >> > implementation. > > > >> >> > > > > >> >> > The current prepare flow works like this > > > >> >> > 1. Call parser.update_project. This includes calling > > > >> >> > parser.update_from_config which updates the platform config a= nd > > > >> >>resources > > > >> >> > based on app config (but only handles specific tags). It also > > > >>updates > > > >> >>the > > > >> >> > platform www based on app www, staging and overrides. > > > >> >> > 2. Call plugman prepare (sets up JS-modules) > > > >> >> > 3. Plugin config-munge (where each plugin config > changes > > > >>are > > > >> >> > iterated > > > >> >> > through) > > > >> >> > > > > >> >> > Braden's proposed flow (in his own words) > > > >> >> > 1. Delete the old platform config.xml. > > > >> >> > 2. Copy the defaults.xml to config.xml. > > > >> >> > 3. Re-run the Plugman config munging for every plugin= , > > > >> >>modifying > > > >> >> > the > > > >> >> > fresh platform config.xml. (The order here is > > > >>deliberately > > > >> >> > undefined; > > > >> >> > plugins should already not be relying on this.) > > > >> >> > 4. Run the config munging for the app=E2=80=99s confi= g.xml as > > well. > > > >> >> > Where I believe #4 means the plugin config-munge. > > > >> >> > > > > >> >> > I'd like to propose the new flow to be the following > > > >> >> > > > > >> >> > 1. If defaults.xml exists, replace platform congig.xm= l > > > >>with it > > > >> >> > 2. Run a generic clobbers from app.xml to platform.xm= l > > that > > > >> >>will > > > >> >> > include > > > >> >> > processing the proposed tags. > > > >> >> > 3. Run plugman config munge on the platform config.xm= l > (I > > > >> >>believe > > > >> >> > this should only add net new elements) > > > >> >> > > > > >> >> > 4. Call a modified parser.update_project that no long= er > > > >>makes > > > >> >> > changes to > > > >> >> > the platform config.xml > > > >> >> > > > > >> >> > I believe that this is complimentary with the approach Braden > > > >> >>suggested > > > >> >> > with one major change. I did not include plugin config mungin= g > on > > > >>the > > > >> >>app > > > >> >> > config.xml. This is because I feel that by doing so we make t= he > > app > > > >> >> > config.xml the same half build artifact half user edited mess > > we're > > > >> >> trying > > > >> >> > to solve. If the list disagrees with me I will of course > > implement > > > >>it > > > >> >>the > > > >> >> > way Braden proposed it though. > > > >> >> > > > > >> >> > > > > >> >> > > > > >> >> > On 13-09-10 1:58 PM, "Jeffrey Heifetz" < > jheifetz@blackberry.com> > > > >> >>wrote: > > > >> >> > > > > >> >> > >Issue Created - https://issues.apache.org/jira/browse/CB-477= 4 > > > >> >> > > > > > >> >> > >On 13-09-10 9:30 AM, "Tommy-Carlos Williams" < > > tommy@devgeeks.org> > > > >> >> wrote: > > > >> >> > > > > > >> >> > >>Then colour me excited! > > > >> >> > >> > > > >> >> > >>+1 > > > >> >> > >> > > > >> >> > >> > > > >> >> > >>On 10/09/2013, at 11:27 PM, Andrew Grieve < > > agrieve@chromium.org> > > > >> >> wrote: > > > >> >> > >> > > > >> >> > >>> On Mon, Sep 9, 2013 at 7:37 PM, Tommy-Carlos Williams > > > >> >> > >>>wrote: > > > >> >> > >>> > > > >> >> > >>>> I have been following this thread with a combination of > > > >>interest > > > >> >>and > > > >> >> > >>>> trepidation. > > > >> >> > >>>> > > > >> >> > >>>> Interest: > > > >> >> > >>>> > > > >> >> > >>>> Anything that works towards ./platforms being a build > > > >>artefact I > > > >> >>am > > > >> >> > >>>>all > > > >> >> > >>>> for. In our app, ./platforms is already a build artefact= . > We > > > >>used > > > >> >> > >>>>hooks to > > > >> >> > >>>> achieve this (updating config files, copying icon / spla= sh > > > >> >>assets, > > > >> >> > >>>>etc). > > > >> >> > >>>> > > > >> >> > >>>> Just a quick question=C5=A0 I know that > ./platforms/../config.xml > > > >> >>(even > > > >> >> > >>>>after a > > > >> >> > >>>> `cordova build =C5=A0`) still has the old defaults for n= ame, > > > >>author, > > > >> >>id > > > >> >> > >>>>etc=C5=A0 but > > > >> >> > >>>> it doesn't seem to make any difference. We don't modify > > > >> >> > >>>> ./platforms/../config.xml as it seemed like the > > modifications > > > >>to > > > >> >> > >>>> ./www/config.xml (and our custom hook modifications to s= ay > > > >> >> > >>>> ./platforms/android/AndroidManifest.xml) were sufficient= . > > > >> >> > >>>> > > > >> >> > >>>> What am I missing wrt there being differences between > these > > > >> >>files? > > > >> >> > >>>> > > > >> >> > >>>> Trepidation: > > > >> >> > >>>> > > > >> >> > >>>> Users are just starting to get a handle on how the CLI > works > > > >> >>(though > > > >> >> > >>>>there > > > >> >> > >>>> are still some ongoing issues that I see fairly regularl= y, > > > >>like > > > >> >> > >>>>thinking > > > >> >> > >>>> they still need to use Plugman directly even with CLI > > created > > > >> >> > >>>>projects). > > > >> >> > >>>> Just worried more workflow changes yet again are going t= o > > turn > > > >> >> people > > > >> >> > >>>>off > > > >> >> > >>>> the CLI entirely. I may be a bit "twice shy", so if it's > not > > > >> >>going > > > >> >> to > > > >> >> > >>>> impact users much (except for making things much better) > > feel > > > >> >>free > > > >> >> to > > > >> >> > >>>>set > > > >> >> > >>>> me straight. hehe. > > > >> >> > >>>> > > > >> >> > >>>> - tommy > > > >> >> > >>>> > > > >> >> > >>> Some clarifications: > > > >> >> > >>> - Change doesn't change workflow at all > > > >> >> > >>> - Change will allow user's edits to their root config.xml > > > >>actually > > > >> >> work > > > >> >> > >>>in > > > >> >> > >>> all cases > > > >> >> > >>> > > > >> >> > >>> Win! > > > >> >> > >>> > > > >> >> > >>> > > > >> >> > >>>> > > > >> >> > >>>> > > > >> >> > >>>> > > > >> >> > >>>> > > > >> >> > >>>> > > > >> >> > >>>> On 10/09/2013, at 2:57 AM, Michal Mocny < > > mmocny@chromium.org> > > > >> >> wrote: > > > >> >> > >>>> > > > >> >> > >>>>> Aside from moving some files around and changing the > order > > of > > > >> >> > >>>>>operations > > > >> >> > >>>> a > > > >> >> > >>>>> bit, the biggest change will be adding support for > > > > > >> >>and > > > >> >> > >>>>> to app.xml. By the way, thats still call= ed > > > >> >> config.xml, > > > >> >> > >>>>>do > > > >> >> > >>>> we > > > >> >> > >>>>> want to rename it to app.xml for 3.1? > > > >> >> > >>>>> > > > >> >> > >>>>> > > > >> >> > >>>>> On Mon, Sep 9, 2013 at 12:47 PM, Braden Shepherdson > > > >> >> > >>>>> > > >> >> > >>>>> wrote: > > > >> >> > >>>>> > > > >> >> > >>>>>> I should certainly be able to. I'm digging into a majo= r > > > >> >> refactoring > > > >> >> > >>>>>>of > > > >> >> > >>>>>> Plugman right now, though, so I'll probably want to > finish > > > >> >>that. > > > >> >> If > > > >> >> > >>>>>>it's > > > >> >> > >>>>>> taking too long, though, then I'll switch gears and ge= t > > > >>this in > > > >> >> > >>>>>>before > > > >> >> > >>>> we > > > >> >> > >>>>>> cut 3.1. > > > >> >> > >>>>>> > > > >> >> > >>>>>> Braden > > > >> >> > >>>>>> > > > >> >> > >>>>>> > > > >> >> > >>>>>> On Mon, Sep 9, 2013 at 11:48 AM, Michal Mocny < > > > >> >> mmocny@chromium.org> > > > >> >> > >>>> wrote: > > > >> >> > >>>>>> > > > >> >> > >>>>>>> Braden, are you going to be able to take this on this > > > >>week? I > > > >> >> > >>>>>>>think it > > > >> >> > >>>>>>> would make the upgrade from 3.0 much easier. > > > >> >> > >>>>>>> > > > >> >> > >>>>>>> -Michal > > > >> >> > >>>>>>> > > > >> >> > >>>>>>> > > > >> >> > >>>>>>> On Mon, Sep 9, 2013 at 9:48 AM, Michal Mocny < > > > >> >> mmocny@chromium.org> > > > >> >> > >>>> wrote: > > > >> >> > >>>>>>> > > > >> >> > >>>>>>>> If you would use a different helloworld app template > > > >>(which > > > >> >>is > > > >> >> now > > > >> >> > >>>>>>>> possible to specify in both CLI and old workflow), > then > > > >>the > > > >> >> > >>>>>>> pre-generatred > > > >> >> > >>>>>>>> platform config.xml template would likely be the wro= ng > > > >>one, > > > >> >>and > > > >> >> > >>>>>>>>thus > > > >> >> > >>>>>>> this > > > >> >> > >>>>>>>> bundling for self documentation would be a disservic= e. > > > >> >> > >>>>>>>> > > > >> >> > >>>>>>>> I don't see very much value in documentation for > > bundling > > > >>the > > > >> >> > >>>> config.xml > > > >> >> > >>>>>>>> inside the platform template (when do we suspect use= rs > > > >>look > > > >> >>at > > > >> >> > >>>>>>>>that > > > >> >> > >>>>>>> file, > > > >> >> > >>>>>>>> as apposed to whats actually generated inside their > > > >> >>project?). > > > >> >> > >>>>>>>>Users > > > >> >> > >>>>>>> can > > > >> >> > >>>>>>>> read what is generated after adding a platform for > their > > > >> >> specific > > > >> >> > >>>>>>>>app > > > >> >> > >>>>>>> using > > > >> >> > >>>>>>>> their chosen flow. > > > >> >> > >>>>>>>> > > > >> >> > >>>>>>>> I think that since bin/create can mush defaults.xml > with > > > >> >>app.xml > > > >> >> > >>>>>>>>for > > > >> >> > >>>>>>> both > > > >> >> > >>>>>>>> flows, it should. > > > >> >> > >>>>>>>> > > > >> >> > >>>>>>>> > > > >> >> > >>>>>>>> On Mon, Sep 9, 2013 at 9:21 AM, Ian Clelland > > > >> >> > >>>>>>>> > > >> >> > >>>>>>>> wrote: > > > >> >> > >>>>>>>> > > > >> >> > >>>>>>>>> On Mon, Sep 9, 2013 at 8:45 AM, Braden Shepherdson = < > > > >> >> > >>>>>>> braden@chromium.org > > > >> >> > >>>>>>>>>> wrote: > > > >> >> > >>>>>>>>> > > > >> >> > >>>>>>>>>> The defaults.xml is only part of the CLI workflow, > > yes. > > > >>It > > > >> >>has > > > >> >> > >>>>>>>>>>no > > > >> >> > >>>>>>>>> relevance > > > >> >> > >>>>>>>>>> if you're not using CLI. BUT there is a complete > > > >> >>config.xml in > > > >> >> > >>>>>>>>>>the > > > >> >> > >>>>>>>>>> bin/create template, and it can of course have the > > same > > > >> >>values > > > >> >> > >>>>>>>>>>as > > > >> >> > >>>> you > > > >> >> > >>>>>>>>> would > > > >> >> > >>>>>>>>>> get from an unchanged CLI project (defaults.xml + > > > >>app.xml). > > > >> >> The > > > >> >> > >>>>>>>>>> configuration values you get from the templates > should > > > >>be > > > >> >>the > > > >> >> > >>>>>>>>>>same > > > >> >> > >>>> in > > > >> >> > >>>>>>>>> both > > > >> >> > >>>>>>>>>> cases, I agree completely. > > > >> >> > >>>>>>>>>> > > > >> >> > >>>>>>>>> > > > >> >> > >>>>>>>>> Yes, I think it's definitely achievable to have the > > > >>complete > > > >> >> > >>>>>>>>>template > > > >> >> > >>>>>>>>> config.xml be exactly what you would get (modulo > > > >>whitespace > > > >> >>/ > > > >> >> > >>>> comments > > > >> >> > >>>>>>> / > > > >> >> > >>>>>>>>> etc) from installing the same sample app on the sam= e > > > >> >>platform > > > >> >> > >>>>>>>>>with > > > >> >> > >>>> CLI. > > > >> >> > >>>>>>>>> > > > >> >> > >>>>>>>>> If we can maintain that standard, then the various > > files > > > >> >>become > > > >> >> > >>>> almost > > > >> >> > >>>>>>>>> self-documenting; its easy to look at the final > > > >>config.xml > > > >> >>file > > > >> >> > >>>>>>>>>in > > > >> >> > >>>> the > > > >> >> > >>>>>>>>> template to see how the pieces should fit together, > and > > > >>work > > > >> >> out > > > >> >> > >>>> where > > > >> >> > >>>>>>>>> each > > > >> >> > >>>>>>>>> of the tags originally came from. > > > >> >> > >>>>>>>>> > > > >> >> > >>>>>>>>> It might be worth trying to generate the template > > > >>config.xml > > > >> >> > >>>>>>>>>*using* > > > >> >> > >>>>>>> cli, > > > >> >> > >>>>>>>>> just to maintain the correspondence between them. > > > >> >> > >>>>>>>>> > > > >> >> > >>>>>>>>> Ian > > > >> >> > >>>>>>>>> > > > >> >> > >>>>>>>>> > > > >> >> > >>>>>>>>>> Braden > > > >> >> > >>>>>>>>>> > > > >> >> > >>>>>>>>>> > > > >> >> > >>>>>>>>>> On Sun, Sep 8, 2013 at 5:28 AM, James Jong > > > >> >> > >>>>>>>>>> > > > >> >> > >>>>>>>>> wrote: > > > >> >> > >>>>>>>>>> > > > >> >> > >>>>>>>>>>> Andrew - what I was thinking was pretty much what > > > >>Michal > > > >> >> wrote > > > >> >> > >>>>>>> below. > > > >> >> > >>>>>>>>>>> Perhaps it was my interpretation of the original > note > > > >>but > > > >> >>I > > > >> >> > >>>>>>> thought > > > >> >> > >>>>>>>>>>> defaults was to be applied only in the CLI > workflow. > > > >> >> > >>>>>>>>>>> > > > >> >> > >>>>>>>>>>> -James Jong > > > >> >> > >>>>>>>>>>> > > > >> >> > >>>>>>>>>>> On Sep 7, 2013, at 1:05 PM, Michal Mocny < > > > >> >> mmocny@chromium.org> > > > >> >> > >>>>>>> wrote: > > > >> >> > >>>>>>>>>>> > > > >> >> > >>>>>>>>>>>> With this proposal as it stands, I think that is > > > >>already > > > >> >> true > > > >> >> > >>>>>>>>>>>>(at > > > >> >> > >>>>>>>>> least > > > >> >> > >>>>>>>>>>> for > > > >> >> > >>>>>>>>>>>> the initial contents, obviously user can make > edits > > > >> >>later). > > > >> >> > >>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>> Ie, defaults.xml + app.xml =3D initial config.xm= l > for > > > >>both > > > >> >> > >>>>>>>>>>>>cases, > > > >> >> > >>>>>>>>> which > > > >> >> > >>>>>>>>>> use > > > >> >> > >>>>>>>>>>>> the same helloworld template's app.xml. > > > >> >> > >>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>> If there are specific differences to the default > > > >>values > > > >> >>that > > > >> >> > >>>>>>>>>>>>we > > > >> >> > >>>>>>>>> want, > > > >> >> > >>>>>>>>>> we > > > >> >> > >>>>>>>>>>>> maybe will want to use a different app.xml for > each, > > > >>but > > > >> >> > >>>>>>>>> defaults.xml > > > >> >> > >>>>>>>>>>>> should be tied to a platform-version not to a > > > >>workflow. > > > >> >> > >>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>> -Michal > > > >> >> > >>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>> On Sat, Sep 7, 2013 at 7:56 AM, Andrew Grieve < > > > >> >> > >>>>>>> agrieve@chromium.org > > > >> >> > >>>>>>>>>> > > > >> >> > >>>>>>>>>>> wrote: > > > >> >> > >>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>> James - that's a nice goal, but I don't think > it's > > > >> >> feasible. > > > >> >> > >>>>>>>>>>>>>Did > > > >> >> > >>>>>>>>> you > > > >> >> > >>>>>>>>>>> have a > > > >> >> > >>>>>>>>>>>>> way to do that in mind? > > > >> >> > >>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>> On Fri, Sep 6, 2013 at 10:31 PM, James Jong < > > > >> >> > >>>>>>> wjamesjong@gmail.com> > > > >> >> > >>>>>>>>>>> wrote: > > > >> >> > >>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>> I would like to see the defaults be applied in > all > > > >> >>cases. > > > >> >> > >>>>>>>>>>>>>>For > > > >> >> > >>>>>>>>>>>>>> consistency, less confusion, and easier > > > >>documentation. > > > >> >> If > > > >> >> > >>>>>>>>>>>>>>we > > > >> >> > >>>>>>> add > > > >> >> > >>>>>>>>> or > > > >> >> > >>>>>>>>>>>>> change > > > >> >> > >>>>>>>>>>>>>> the defaults in a release, both workflows shou= ld > > get > > > >> >>it. > > > >> >> In > > > >> >> > >>>>>>>>>>>>>>my > > > >> >> > >>>>>>>>> mind, > > > >> >> > >>>>>>>>>>> the > > > >> >> > >>>>>>>>>>>>>> CLI platform config.xml should be equivalent t= o > > the > > > >> >> > >>>>>>>>>>>>>>bin/create > > > >> >> > >>>>>>>>> one. > > > >> >> > >>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>> -James Jong > > > >> >> > >>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>> On Sep 6, 2013, at 11:06 AM, Michal Mocny > > > >> >> > >>>>>>>>>>>>>> > > >> >> > >>>>>>>> > > > >> >> > >>>>>>>>>> wrote: > > > >> >> > >>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>> I thought we were adding support for the last > bit > > > >>(ie, > > > >> >> app > > > >> >> > >>>>>>>>> generic > > > >> >> > >>>>>>>>>> not > > > >> >> > >>>>>>>>>>>>>>> platform specific preferences) to "app.xml" > which > > > >>the > > > >> >> > >>>>>>> helloworld > > > >> >> > >>>>>>>>>>>>> template > > > >> >> > >>>>>>>>>>>>>>> should ship with and bin/create should apply. > > > >> >> > >>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>> -Michal > > > >> >> > >>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>> On Fri, Sep 6, 2013 at 10:52 AM, Ian Clelland= < > > > >> >> > >>>>>>>>>> iclelland@chromium.org > > > >> >> > >>>>>>>>>>>>>>> wrote: > > > >> >> > >>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>> The template version needs to be a complete > > config > > > >> >>file > > > >> >> > >>>>>>>>>>>>>>>>for > > > >> >> > >>>>>>> the > > > >> >> > >>>>>>>>>>> sample > > > >> >> > >>>>>>>>>>>>>> app, > > > >> >> > >>>>>>>>>>>>>>>> though. You should be able to run bin/create > and > > > >>then > > > >> >> > >>>>>>>>>>>>>>>>build > > > >> >> > >>>>>>> the > > > >> >> > >>>>>>>>>>> Hello, > > > >> >> > >>>>>>>>>>>>>>>> Cordova app immediately. > > > >> >> > >>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>> defaults.xml is supposed to be stripped righ= t > > > >>down to > > > >> >> just > > > >> >> > >>>>>>> the > > > >> >> > >>>>>>>>>>>>>>>> platform-specific options which, in theory, > > > >>shouldn't > > > >> >> need > > > >> >> > >>>>>>> to be > > > >> >> > >>>>>>>>>>>>>> specified > > > >> >> > >>>>>>>>>>>>>>>> by every app. > > > >> >> > >>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>> At least that's how it works in my head :) T= he > > > >> >> distinction > > > >> >> > >>>>>>> may > > > >> >> > >>>>>>>>> be > > > >> >> > >>>>>>>>>>> less > > > >> >> > >>>>>>>>>>>>>>>> important than I'm imagining. > > > >> >> > >>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>> Ian > > > >> >> > >>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>> On Fri, Sep 6, 2013 at 9:08 AM, Michal Mocny= < > > > >> >> > >>>>>>>>> mmocny@chromium.org> > > > >> >> > >>>>>>>>>>>>>> wrote: > > > >> >> > >>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>> If the content or format of defaults.xml an= d > > the > > > >> >> initial > > > >> >> > >>>>>>>>>> config.xml > > > >> >> > >>>>>>>>>>>>>> will > > > >> >> > >>>>>>>>>>>>>>>> be > > > >> >> > >>>>>>>>>>>>>>>>> different then we should ship both -- but I > > don't > > > >> >>think > > > >> >> > >>>>>>>>>>>>>>>>>they > > > >> >> > >>>>>>>>> will > > > >> >> > >>>>>>>>>>> be, > > > >> >> > >>>>>>>>>>>>>> so > > > >> >> > >>>>>>>>>>>>>>>> I > > > >> >> > >>>>>>>>>>>>>>>>> think we just ship the template with a > defaults > > > >> >>file. > > > >> >> > >>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>> -Michal > > > >> >> > >>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>> On Thu, Sep 5, 2013 at 11:19 PM, Ian > Clelland < > > > >> >> > >>>>>>>>>>>>> iclelland@chromium.org > > > >> >> > >>>>>>>>>>>>>>>>>> wrote: > > > >> >> > >>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>> On Thu, Sep 5, 2013 at 5:16 PM, James Jong= < > > > >> >> > >>>>>>>>> wjamesjong@gmail.com > > > >> >> > >>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>> wrote: > > > >> >> > >>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>> defaults.xml - Is that only used by CLI? > And > > > >>not > > > >> >> used > > > >> >> > >>>>>>>>>>>>>>>>>>>by > > > >> >> > >>>>>>>>>>>>> bin/create > > > >> >> > >>>>>>>>>>>>>>>>>>> scripts? > > > >> >> > >>>>>>>>>>>>>>>>>>> It was bit unclear to me from the > description > > > >> >>since > > > >> >> > >>>>>>>>>>>>>>>>>>>both > > > >> >> > >>>>>>> were > > > >> >> > >>>>>>>>>>>>>>>> mentioned > > > >> >> > >>>>>>>>>>>>>>>>>>> regarding the 2 xml files. > > > >> >> > >>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>> Yes, that's the idea. If you're using the > > > >> >>bin/create > > > >> >> > >>>>>>> scripts, > > > >> >> > >>>>>>>>>> then > > > >> >> > >>>>>>>>>>>>>>>> there > > > >> >> > >>>>>>>>>>>>>>>>> is > > > >> >> > >>>>>>>>>>>>>>>>>> a complete "config.xml" file in the templa= te > > > >>that > > > >> >>will > > > >> >> > >>>>>>>>>>>>>>>>>>be > > > >> >> > >>>>>>> used > > > >> >> > >>>>>>>>>> for > > > >> >> > >>>>>>>>>>>>>> your > > > >> >> > >>>>>>>>>>>>>>>>> new > > > >> >> > >>>>>>>>>>>>>>>>>> app. This is for strict backwards > > compatibility > > > >> >>with > > > >> >> > >>>>>>> anyone's > > > >> >> > >>>>>>>>>>>>> workflow > > > >> >> > >>>>>>>>>>>>>>>>> that > > > >> >> > >>>>>>>>>>>>>>>>>> doesn't currently include CLI. > > > >> >> > >>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>> If you are using CLI, then we will > construct a > > > >>new > > > >> >> > >>>>>>> config.xml > > > >> >> > >>>>>>>>>> file > > > >> >> > >>>>>>>>>>>>> for > > > >> >> > >>>>>>>>>>>>>>>>> you > > > >> >> > >>>>>>>>>>>>>>>>>> instead, from three sources: defaults.xml, > > which > > > >> >> > >>>>>>>>>>>>>>>>>>specifies > > > >> >> > >>>>>>>>> all of > > > >> >> > >>>>>>>>>>>>> the > > > >> >> > >>>>>>>>>>>>>>>>>> platform defaults; the various plugin.xml > > files, > > > >> >>and > > > >> >> > >>>>>>>>>>>>>>>>>>your > > > >> >> > >>>>>>>>> app's > > > >> >> > >>>>>>>>>>>>>>>>> config.xml > > > >> >> > >>>>>>>>>>>>>>>>>> file. The end-result should be the same, b= ut > > you > > > >> >>have > > > >> >> a > > > >> >> > >>>>>>> clear > > > >> >> > >>>>>>>>>> place > > > >> >> > >>>>>>>>>>>>> to > > > >> >> > >>>>>>>>>>>>>>>>>> override the defaults for your app that > lives > > > >> >>outside > > > >> >> of > > > >> >> > >>>>>>> your > > > >> >> > >>>>>>>>>>>>>> platforms > > > >> >> > >>>>>>>>>>>>>>>>>> directory, and the cordova team has a clea= r > > > >>place > > > >> >>to > > > >> >> set > > > >> >> > >>>>>>> those > > > >> >> > >>>>>>>>>> same > > > >> >> > >>>>>>>>>>>>>>>>>> defaults. > > > >> >> > >>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>> Ian > > > >> >> > >>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>> The new CLI prepare flow makes sense to m= e. > > > >> >> > >>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>> -James Jong > > > >> >> > >>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>> On Sep 5, 2013, at 2:21 PM, Michal Mocny = < > > > >> >> > >>>>>>>>> mmocny@chromium.org> > > > >> >> > >>>>>>>>>>>>>>>> wrote: > > > >> >> > >>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>> We briefly discussed JSON and the two > > thoughts > > > >> >>were: > > > >> >> > >>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>> (1) We like it, but really what does it > buy > > > >>us? > > > >> >> > >>>>>>>>>>>>>>>>>>>> (2) This change is at the moment 100% > > > >>compatible > > > >> >> with > > > >> >> > >>>>>>>>>>>>>>>>>>>>all > > > >> >> > >>>>>>>>>> current > > > >> >> > >>>>>>>>>>>>>>>>>>> workflows > > > >> >> > >>>>>>>>>>>>>>>>>>>> (including upgrades from 3.0->3.1), and = we > > > >>think > > > >> >> > >>>>>>>>>>>>>>>>>>>>that's > > > >> >> > >>>>>>>>>> important > > > >> >> > >>>>>>>>>>>>>>>> for > > > >> >> > >>>>>>>>>>>>>>>>>>>> headache-less adoption. JSON would > > obviously > > > >>not > > > >> >> be. > > > >> >> > >>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>> Regarding where to store the defaults, w= e > > had > > > >> >> thought > > > >> >> > >>>>>>>>>>>>>>>>>>>>it > > > >> >> > >>>>>>>>> would > > > >> >> > >>>>>>>>>> be > > > >> >> > >>>>>>>>>>>>> a > > > >> >> > >>>>>>>>>>>>>>>>>> file > > > >> >> > >>>>>>>>>>>>>>>>>>>> bundled with the platform, perhaps in > > > >> >>bin/templates? > > > >> >> > >>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>> -Michal > > > >> >> > >>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>> On Thu, Sep 5, 2013 at 12:38 PM, Brian > > LeRoux > > > >>< > > > >> >> > >>>>>>> b@brian.io> > > > >> >> > >>>>>>>>>>> wrote: > > > >> >> > >>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>> The logic flow is much safer in this > > method. > > > >> >>Where > > > >> >> do > > > >> >> > >>>>>>> you > > > >> >> > >>>>>>>>>> think > > > >> >> > >>>>>>>>>>>>>>>>>>> default.xml > > > >> >> > >>>>>>>>>>>>>>>>>>>>> should live? (Maybe it doesn't have to > > exist > > > >>and > > > >> >> > >>>>>>> defaults > > > >> >> > >>>>>>>>> can > > > >> >> > >>>>>>>>>>>>> just > > > >> >> > >>>>>>>>>>>>>>>>> be > > > >> >> > >>>>>>>>>>>>>>>>>>> vars > > > >> >> > >>>>>>>>>>>>>>>>>>>>> in the logic that does the processing?) > > > >> >> > >>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>> Is this our opportunity to move to JSON= ? > > > >> >> > >>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>> On Thu, Sep 5, 2013 at 8:21 AM, Braden > > > >> >>Shepherdson > > > >> >> < > > > >> >> > >>>>>>>>>>>>>>>>>> braden@chromium.org > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> wrote: > > > >> >> > >>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> config.xml as a build artifact for les= s > > > >> >>suffering > > > >> >> > and > > > >> >> > >>>>>>>>> easier > > > >> >> > >>>>>>>>>>>>>>>>> upgrades > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Terminology > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> =C2=B3platform config.xml=C2=B2 refers= to the > > > >> >> > platform-specific > > > >> >> > >>>>>>>>>>>>>>>> config.xml > > > >> >> > >>>>>>>>>>>>>>>>>>>>> files, > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> eg. > platforms/android/res/xml/config.xml. > > > >>This > > > >> >>is > > > >> >> > the > > > >> >> > >>>>>>>>> final > > > >> >> > >>>>>>>>>>>>>>>> file > > > >> >> > >>>>>>>>>>>>>>>>>> read > > > >> >> > >>>>>>>>>>>>>>>>>>>>> by > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Cordova at runtime. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> =C2=B3app config.xml=C2=B2 refers to t= he top-level > > > >> >> config.xml > > > >> >> > >>>>>>> found > > > >> >> > >>>>>>>>> in > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> www/config.xml. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Why the current situation is suffering > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Chiefly, the > platforms/foo/.../config.xml > > > >>files > > > >> >> are > > > >> >> > >>>>>>> both > > > >> >> > >>>>>>>>> the > > > >> >> > >>>>>>>>>>>>>>>>> input > > > >> >> > >>>>>>>>>>>>>>>>>>> and > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> output of munging by Plugman and the > user. > > > >>This > > > >> >> > sucks. > > > >> >> > >>>>>>> It > > > >> >> > >>>>>>>>>> makes > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> automatic upgrades difficult because > > > >>everybody > > > >> >> has a > > > >> >> > >>>>>>>>>> customized > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> config.xml > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> file in their platforms. It also makes > > > >>plugin > > > >> >>rm > > > >> >> > harder > > > >> >> > >>>>>>>>> and > > > >> >> > >>>>>>>>>>>>>>>> less > > > >> >> > >>>>>>>>>>>>>>>>>>>>> robust > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> in > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> CLI than it needs to be. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Currently only some tags in the app > > > >>config.xml > > > >> >>are > > > >> >> > >>>>>>>>> actually > > > >> >> > >>>>>>>>>>>>>>>>>> honoured. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Others are ignored, and this has tripp= ed > > up > > > >>our > > > >> >> > users. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Goals > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> bin/create workflow is unchanged. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Final content of the platform config.x= ml > > > >>file > > > >> >>is > > > >> >> > >>>>>>>>> unchanged, > > > >> >> > >>>>>>>>>>>>>>>>> though > > > >> >> > >>>>>>>>>>>>>>>>>>> the > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> method of building it in the CLI can > > change. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> CLI workflow is unchanged, in terms of > > what > > > >>a > > > >> >>user > > > >> >> > >>>>>>> types. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> platform config.xml stops being both > input > > > >>and > > > >> >> > output > > > >> >> > >>>>>>>>> under > > > >> >> > >>>>>>>>>>>>>>>> CLI. > > > >> >> > >>>>>>>>>>>>>>>>>> Less > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> munging, and easier upgrades. In short= , > > > >> >>platform > > > >> >> > >>>>>>>>> config.xml > > > >> >> > >>>>>>>>>>>>>>>> files > > > >> >> > >>>>>>>>>>>>>>>>>>>>> become > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> build artifacts. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> What we propose to do about it > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> First, adjust the platform template > (used > > by > > > >> >> > >>>>>>> bin/create) > > > >> >> > >>>>>>>>> to > > > >> >> > >>>>>>>>>>>>>>>>> contain > > > >> >> > >>>>>>>>>>>>>>>>>>>>> two > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> files: > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> defaults.xml, which is versioned, > > > >>immutable, > > > >> >>and > > > >> >> > >>>>>>> tucked > > > >> >> > >>>>>>>>>> away > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> somewhere (only CLI accesses it) and > > > >>contains > > > >> >> only > > > >> >> > >>>>>>> the > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Cordova-specified > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> platform defaults, such as the > > preferences, > > > >> >>any > > > >> >> > >>>>>>> default > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> whitelist entries, > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> etc. It does NOT contain any = , > > > >> > > > >> >>or > > > >> >> > >>>>>>> other > > > >> >> > >>>>>>>>>> such > > > >> >> > >>>>>>>>>>>>>>>>>> tags. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> platform config.xml, which is the sam= e > as > > > >>it > > > >> >> > >>>>>>> currently > > > >> >> > >>>>>>>>>> is, a > > > >> >> > >>>>>>>>>>>>>>>>>>>>> complete > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> config.xml for the HelloWorld app. Th= is > > > >>means > > > >> >> > >>>>>>> behavior > > > >> >> > >>>>>>>>> is > > > >> >> > >>>>>>>>>>>>>>>>>>> unchanged > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> for people who are not using CLI. > Plugman > > > >> >>still > > > >> >> > >>>>>>> munges > > > >> >> > >>>>>>>>>> this > > > >> >> > >>>>>>>>>>>>>>>>> file > > > >> >> > >>>>>>>>>>>>>>>>>>>>> and > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> outputs back to it, same as now. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Second, adjust the CLI=C2=B9s cordova = create > > > >> >>template > > > >> >> so > > > >> >> > >>>>>>> that > > > >> >> > >>>>>>>>> its > > > >> >> > >>>>>>>>>>>>>>>>>>> top-level > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> app config.xml contains , > , > > > >> >> , > > > >> >> > >>>>>>> etc. > > > >> >> > >>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>> tags > > > >> >> > >>>>>>>>>>>>>>>>>> the > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> user is likely to edit. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Third, modify the CLI so that the new > > > >>cordova > > > >> >> > prepare > > > >> >> > >>>>>>> flow > > > >> >> > >>>>>>>>>> is: > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Delete the old platform config.xml. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Copy the defaults.xml to config.xml. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Re-run the Plugman config munging for > > every > > > >> >> plugin, > > > >> >> > >>>>>>>>>>>>>>>> modifying > > > >> >> > >>>>>>>>>>>>>>>>>> the > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> fresh platform config.xml. (The order > > here > > > >>is > > > >> >> > >>>>>>>>> deliberately > > > >> >> > >>>>>>>>>>>>>>>>>>>>> undefined; > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> plugins should already not be relying > on > > > >> >>this.) > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Run the config munging for the app=C2= =B9s > > > >> >>config.xml > > > >> >> as > > > >> >> > >>>>>>>>> well. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> This results in a freshly built, > > > >> >>build-artifact > > > >> >> > >>>>>>>>> platform > > > >> >> > >>>>>>>>>>>>>>>>>>>>> config.xml. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Users should not be editing it; their > > > >> >>top-level > > > >> >> app > > > >> >> > >>>>>>>>>>>>>>>> config.xml > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> has the last > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> word and will override any settings t= he > > > >> >>defaults > > > >> >> or > > > >> >> > >>>>>>>>>> plugins > > > >> >> > >>>>>>>>>>>>>>>>>> might > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> make. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Note that this means we shouldn=C2= =B9t be > > > >> >> needlessly > > > >> >> > >>>>>>>>> setting > > > >> >> > >>>>>>>>>>>>>>>>>>> defaults > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> in the app config.xml, since this > > might > > > >> >> prevent > > > >> >> > >>>>>>>>>> plugins > > > >> >> > >>>>>>>>>>>>>>>>> from > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> changing > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> things that need changing. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Fourth, extend the app config.xml form= at > > so > > > >> >>that > > > >> >> it > > > >> >> > can > > > >> >> > >>>>>>>>> have > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> tags, like a plugin.xml. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> Into this it can put platform-specifi= c > > > >>things > > > >> >> like > > > >> >> > >>>>>>>>>>>>>>>>>> splashscreens, > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> preferences and other things, rather > than > > > >> >>mixing > > > >> >> > >>>>>>> these > > > >> >> > >>>>>>>>>>>>>>>>> together > > > >> >> > >>>>>>>>>>>>>>>>>> in > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> the > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> config. > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> - > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> In particular, it can have > > > > >>tags > > > >> >>in > > > >> >> > the > > > >> >> > >>>>>>>>> usual > > > >> >> > >>>>>>>>>>>>>>>>>> format > > > >> >> > >>>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>>>> > > > >> >> > >>>>>>>>>>> > > > >> >> > >>>>>>>>>>> > > > >> >> > >>>>>>>>>> > > > >> >> > >>>>>>>>> > > > >> >> > >>>>>>>> > > > >> >> > >>>>>>>> > > > >> >> > >>>>>>> > > > >> >> > >>>>>> > > > >> >> > >>>>>> > > > >> >> > >>>> > > > >> >> > >>>> > > > >> >> > >> > > > >> >> > > > > > >> >> > > > > > >> >> > > > > > >>>--------------------------------------------------------------------- > > > >> >> > >This transmission (including any attachments) may contain > > > >> >>confidential > > > >> >> > >information, privileged material (including material protect= ed > > by > > > >>the > > > >> >> > >solicitor-client or other applicable privileges), or > constitute > > > >> >> > >non-public information. Any use of this information by anyon= e > > > >>other > > > >> >>than > > > >> >> > >the intended recipient is prohibited. If you have received > this > > > >> >> > >transmission in error, please immediately reply to the sende= r > > and > > > >> >>delete > > > >> >> > >this information from your system. Use, dissemination, > > > >>distribution, > > > >> >>or > > > >> >> > >reproduction of this transmission by unintended recipients i= s > > not > > > >> >> > >authorized and may be unlawful. > > > >> >> > > > > >> >> > > > > >> >> > > > > >>-------------------------------------------------------------------= -- > > > >> >> > This transmission (including any attachments) may contain > > > >>confidential > > > >> >> > information, privileged material (including material protecte= d > by > > > >>the > > > >> >> > solicitor-client or other applicable privileges), or constitu= te > > > >> >> non-public > > > >> >> > information. Any use of this information by anyone other than > the > > > >> >> intended > > > >> >> > recipient is prohibited. If you have received this transmissi= on > > in > > > >> >>error, > > > >> >> > please immediately reply to the sender and delete this > > information > > > >> >>from > > > >> >> > your system. Use, dissemination, distribution, or reproductio= n > of > > > >>this > > > >> >> > transmission by unintended recipients is not authorized and m= ay > > be > > > >> >> unlawful. > > > >> >> > > > > >> >> > > > >> > > > >> > --------------------------------------------------------------------- > > > >> This transmission (including any attachments) may contain > confidential > > > >> information, privileged material (including material protected by > the > > > >> solicitor-client or other applicable privileges), or constitute > > > >>non-public > > > >> information. Any use of this information by anyone other than the > > > >>intended > > > >> recipient is prohibited. If you have received this transmission in > > > >>error, > > > >> please immediately reply to the sender and delete this information > > from > > > >> your system. Use, dissemination, distribution, or reproduction of > this > > > >> transmission by unintended recipients is not authorized and may be > > > >>unlawful. > > > >> > > > > > > --------------------------------------------------------------------- > > > This transmission (including any attachments) may contain confidentia= l > > > information, privileged material (including material protected by the > > > solicitor-client or other applicable privileges), or constitute > > non-public > > > information. Any use of this information by anyone other than the > > intended > > > recipient is prohibited. If you have received this transmission in > error, > > > please immediately reply to the sender and delete this information fr= om > > > your system. Use, dissemination, distribution, or reproduction of thi= s > > > transmission by unintended recipients is not authorized and may be > > unlawful. > > > > > > --089e013a2b0893d99704e6869643--