cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse <purplecabb...@gmail.com>
Subject Re: CB-4900 device-orientation windows8 code review?
Date Wed, 25 Sep 2013 17:47:17 GMT
Never mind that last request, way to easy to mix up device-motion and
device-orientation, who named this stuff?

@purplecabbage
risingj.com


On Wed, Sep 25, 2013 at 10:40 AM, Jesse <purplecabbage@gmail.com> wrote:

> It's good, I'd pull it in, but there are merge issues.
> Can you update to include the latest commits to the dev branch?
>
> @purplecabbage
> risingj.com
>
>
> On Wed, Sep 25, 2013 at 10:12 AM, Carlos Santana <csantana23@gmail.com>wrote:
>
>> Can someone review this proposed fix and if OK merge into dev?
>>
>> Windows 8 Compass plugin have extra define breaks plugin loading:
>>
>> https://issues.apache.org/jira/browse/CB-4900
>>
>> https://github.com/apache/cordova-plugin-device-orientation/pull/3
>>
>> --
>> Carlos Santana
>> <csantana23@gmail.com>
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message