cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Santana <csantan...@gmail.com>
Subject Re: bbwp vs. blackberry-nativepackager?
Date Fri, 20 Sep 2013 18:26:15 GMT
Thanks Bryan

I think I understand now most of the node js script in cordova are also
present in webworks sdk

1. I think cordova should create a valid config.xml to be use by
blackberry10 platform.
2. We should use updated code to validate that config.xml is a valid file
even with user additions
3. Since we required the sdk anyway why have an old copy of the same files
in cordova and not leverage the ones present in sdk?

config-parser.js in cordova is different in than webworks config.parser.js

function createAccessListObj(uri, allowSubDomain) {
    return {
        uri: uri,
        allowSubDomain: allowSubDomain
    };
}

vs in webworks
function createAccessListObj(featuresArray, uri, allowSubDomain) {
    return {
        features: featuresArray,
        uri: uri,
        allowSubDomain: allowSubDomain
    };
}

resulting in different validations in function
config-parser.js: function validateConfig(widgetConfig)
if (access.features) {
                // Assert each feature has a proper ID and is not empty
                access.features.forEach(function (feature) {
                    if (!feature) {
                        throw
localize.translate("EXCEPTION_INVALID_FEATURE_ID");
                    }
                    check(feature.id,
localize.translate("EXCEPTION_INVALID_FEATURE_ID")).notNull().notEmpty();
                });
            }

Should I filed a bug to add <feature "id" ..> to all cordova plugins and
update config-parser.js in cordova?

--Carlos



On Fri, Sep 20, 2013 at 2:08 PM, Bryan Higgins <bryan@bryanhiggins.net>wrote:

> The tools are not compatible. In fact, most of the source from bbwp has
> been contributed into Cordova.
>
>
> On Fri, Sep 20, 2013 at 1:54 PM, Carlos Santana <csantana23@gmail.com
> >wrote:
>
> > I see that cordova 3.x uses blackberry-nativepackager instead of bbwp
> >
> > Any known problems with using bbwp?
> > Is bbwp not supported as a method to package a Cordova App?
> >
> > When using bbwp on an App created with Cordova 3 it errors on validation
> > config.xml
> >
> > <feature> tag missing attribute "id"
> >
> > <feature name="Camera" value="Camera" />
> >
> > adding "id" makes validation pass
> >
> > <feature id="Camera" name="Camera" value="Camera" />
> >
> > Shouldn't according to BB docs feature only contain "id" and nothign
> else?
> >
> > like this
> >
> > <feature id="Camera"  />
> >
> >
> http://developer.blackberry.com/html5/documentation/feature_element_834678_11.html
> >
> > Syntax
> > <feature id="string"
> >          required=["true" | "false"]
> >          version="string" />
> >
> > --
> > Carlos Santana
> > <csantana23@gmail.com>
> >
>



-- 
Carlos Santana
<csantana23@gmail.com>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message