cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0
Date Fri, 27 Sep 2013 00:54:37 GMT
Published the branch on apache/cordova-ios/CB-4935 (see the issue for the
specific branch commit)
Decided to make the settings dynamic, although HideKeyboardFormAccessoryBar
can't be "unhidden" currently - so that setting is readonly (there's a
TODO: in there)


On Thu, Sep 26, 2013 at 4:48 PM, Shazron <shazron@gmail.com> wrote:

> I've added https://issues.apache.org/jira/browse/CB-4935
>
> Scheduled this for 3.2.0 - I've already got this working in a branch on
> cordova-ios actually (will publish to the branch EOD). I suppose it could
> go to cordova-labs?
>
>
> On Thu, Sep 26, 2013 at 1:56 PM, Michal Mocny <mmocny@chromium.org> wrote:
>
>> You mean put it within cordova-labs/plugins?  I agree it should start life
>> there.  I don't think plugins should live in the platform repos, even if
>> they are currently platform specific.
>>
>>
>> On Thu, Sep 26, 2013 at 4:11 PM, Andrew Grieve <agrieve@chromium.org>
>> wrote:
>>
>> > Makes sense to me if taking it out is feasible code-wise. Would
>> encourage
>> > people to fork / fiddle with it themselves as well I think.
>> >
>> > Now that we have a registry, we don't need to create new repos for them
>> > (yay!). Maybe just put the plugins within cordova-ios/plugins?
>> >
>> > I think we'll need to wait until after 3.1 to rip it out.
>> >
>> >
>> > On Wed, Sep 25, 2013 at 2:22 AM, James Jong <wjamesjong@gmail.com>
>> wrote:
>> >
>> > > +1 Separating this from the core into a plugin is a good idea.
>> > >
>> > > Not sure that this fits into any existing plugin though.
>> > >
>> > > -James Jong
>> > >
>> > > On Sep 24, 2013, at 2:37 PM, Shazron <shazron@gmail.com> wrote:
>> > >
>> > > > Issue: https://issues.apache.org/jira/browse/CB-3020
>> > > >
>> > > > I've got it mostly working but I'm thinking this really should move
>> to
>> > a
>> > > > plugin, perhaps reside in an existing one?
>> > > >
>> > > > The things we are doing with hiding the keyboard accessory bar and
>> > > > shrinking the view etc are hackish and might break with any iOS
>> update,
>> > > and
>> > > > imo fixes should not be tied to a core release.
>> > > >
>> > > > My proposal is to move the code for the two keyboard preferences to
>> a
>> > > > plugin.
>> > >
>> > >
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message