cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian LeRoux...@brian.io>
Subject Re: [Android] Why did we check in shelljs?
Date Wed, 11 Sep 2013 19:27:31 GMT
Ya, vendoring/shrink wrapping considered best practice in Node land.
On Sep 11, 2013 10:33 AM, "Andrew Grieve" <agrieve@chromium.org> wrote:

> Yeah, I just did that yesterday. That was my main feedback to Benn when he
> announced the conversion to node for the android scripts.
>
> Rule of thumb is when you're distributing a tool, you should check in your
> node_modules. Our build scripts fit into this bucket I think.
>
>
> On Wed, Sep 11, 2013 at 1:10 PM, Joe Bowser <bowserj@gmail.com> wrote:
>
> > It's in bin/node_modules.  I understand the need for this for build
> > scripts, but shouldn't we tell people to npm update?
> >
> > On Wed, Sep 11, 2013 at 10:08 AM, Braden Shepherdson
> > <braden@chromium.org> wrote:
> > > Where is this? That sounds odd.
> > >
> > >
> > > On Wed, Sep 11, 2013 at 1:06 PM, Joe Bowser <bowserj@gmail.com> wrote:
> > >
> > >> Any reason why? I'm wondering if this was done to help people who
> > >> don't use node or something.
> > >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message