cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: [Android] FileHelper and DirectoryManager removed, breaks two core plugins
Date Wed, 11 Sep 2013 15:14:36 GMT
Restored & Deprecated.


On Wed, Sep 11, 2013 at 11:07 AM, Andrew Grieve <agrieve@chromium.org>wrote:

> That's good feedback. I was flip floppy about actually removing the files
> from core, but sounds like there's good reason to leave them for now. I'll
> put them back and deprecate them. Also unsure about whether it merits a
> major version bump, since these classes aren't (intentionally) a part of
> our API, but rather files that didn't get moved into the plugins in time.
>
> The copies of them in the plugins have the same name, but are in different
> packages, so they won't conflict.
>
>
>
> On Wed, Sep 11, 2013 at 9:14 AM, Ian Clelland <iclelland@chromium.org>wrote:
>
>> On Wed, Sep 11, 2013 at 5:44 AM, Andrew Grieve <agrieve@chromium.org>
>> wrote:
>>
>> > From your other thread, I think you figured out the case here - but the
>> > breaking case will be if you are using non-latest plugins with latest
>> > android.
>> >
>>
>> This is still a possibility -- I hit it yesterday as well, by updating one
>> repo and not the other.
>>
>> Given that the core and the plugins are separated now, the API surface is
>> even more of a contract than it was before, and I think we need to be more
>> careful about trying to make coordinated changes between plugins and core.
>>
>> I would have liked to have seen the symbols moved into the plugin, under a
>> different name, and then, only later (say, with the next major release of
>> Cordova) have the old symbols removed. We could annotate them as
>> deprecated
>> in the meantime to inform anyone else using them.
>>
>> It's slower, but it won't break things. (As often, at least). And the
>> stability should help with developer confidence that we won't continue to
>> have breaking changes in Cordova with every monthly release.
>>
>> Ian
>>
>>
>> > This *does* mean that when we release 3.1, it will require that users
>> > update some of their plugins if they haven't already. I think this is
>> > reasonable though?
>> >
>> >
>> > On Tue, Sep 10, 2013 at 5:03 PM, Joe Bowser <bowserj@gmail.com> wrote:
>> >
>> > > Hey
>> > >
>> > > I noticed that FileHelper and DirectoryManager were removed from the
>> > > Core cordova, and now AudioHandler and Capture no longer function. Can
>> > > we please not just move things without making sure that they aren't
>> > > plagued with dependencies and making sure the plugins are updated?
>> > > There's a reason I didn't rip these things out of Cordova earlier.
>> > >
>> > > Joe
>> > >
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message