cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: Android platform scripts
Date Fri, 27 Sep 2013 16:47:41 GMT
SGTM. shelljs is used for other things though, so we won't be able to get
rid of it.


On Fri, Sep 27, 2013 at 4:13 PM, Braden Shepherdson <braden@chromium.org>wrote:

> The Android platform scripts use shelljs.exec's synchronous mode. This is a
> terrible hack that leaks filehandles by the hundred, wastes lots of CPU
> cycles, and can cause EMFILE on OSX because it runs out of filehandles.
>
> I wanted to rewrite the scripts to be async and use child_process.exec or
> .spawn. I started to, but rapidly found that the tangle of callbacks that
> resulted was terrible and confusing.
>
> I propose using Q.js here as well (and dropping shelljs as a dependency, if
> it was only ever used for .exec).
>
> Any objections?
>
> Braden
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message