Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (athena.apache.org: domain of iclelland@google.com
 designates 209.85.219.41 as permitted sender)
MIME-Version: 1.0
Sender: iclelland@google.com
In-Reply-To: 
 <268a322d3825468f970158bd716d8628@BN1PR07MB135.namprd07.prod.outlook.com>
References: 
 <268a322d3825468f970158bd716d8628@BN1PR07MB135.namprd07.prod.outlook.com>
From: Ian Clelland <iclelland@chromium.org>
Date: Sun, 18 Aug 2013 22:25:54 -0400
Message-ID: 
 <CAK_TSX+8_PL_giCdvTTE741Q2t4GKfU2EM4CnZjGvLeQSBpO5w@mail.gmail.com>
Subject: Re: Cordova Gesture plugin
To: "dev@cordova.apache.org" <dev@cordova.apache.org>,
 Jonathan Bond-Caron <jbondc@gdesolutions.com>
Content-Type: multipart/alternative; boundary=001a11c2e81c176dc204e443aa46

--001a11c2e81c176dc204e443aa46
Content-Type: text/plain; charset=UTF-8

On Sun, Aug 18, 2013 at 12:54 PM, Jonathan Bond-Caron <
jbondc@gdesolutions.com> wrote:

> I participated at a #hackmtl event in Montreal and thought it would be a
> good opportunity to try building a 'Cordova Gesture' plugin:
> https://github.com/jbondc/cordova-plugin-gesture


That looks really interesting as a project -- I'm excited about the
possibilty of standardising the idea of "gesture recognition" across
platforms.

My first time using 3.0.0 went very smoothly, the simple command line tools
> are great.
>
> Unfortunately I didn't complete the 'proof-of-concept' since I got stuck
> where the javascript plugin seems to load but fails:
> https://issues.apache.org/jira/browse/CB-4609


Is this preventing any plugins from working at all, or is it just something
about your new plugin?

The only thing that I can see that's a bit odd in your plugin is the
android-feature line in plugin.xml:

<param name="android-package" value="org.apache.cordova.core"/>

That value, I think, should end with the class that extends CordovaPlugin,
namely "Gesture".


>
> An important note for the plugin to be viable, 2 methods would need to be
> added to 'CordovaWebView':
> disableTouchEvents()
> registerGestureHandler()
>
>
I'm actually working on a patch that should make it easier for an
application to provide a custom WebView class that extends CordovaWebView,
but I'm not sure how feasible it is for plugins to do the same. We might
have to look at other ways of overriding methods like those (because I'm
sure that they won't be the last ones).


> The code works by intercepting the 'onTouchEvent', tries to detect a
> gesture and pass it directly to the DOM:
>
> https://github.com/jbondc/mtlhack-PhoneGap-gesture/blob/master/cordova/platforms/android/src/org/hackmtl/phonegap/gestures/TestWebView.java
>
> Feel free to fork away and provide feedback,
> Cheers, Jon
>
>
Ian

--001a11c2e81c176dc204e443aa46--