Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of mmocny@google.com designates
 74.125.83.44 as permitted sender)
MIME-Version: 1.0
Sender: mmocny@google.com
In-Reply-To: 
 <CANpVHHzZd=59HDQO+h-8EaK-EjuqEu4bnQLk7nF38tFUD8dkdw@mail.gmail.com>
References: 
 <CAM2q_UxW1uJAhCBqsqerAWf7J7a9xZejCjMDa-XgOrX+S23AUg@mail.gmail.com>
 <CABaSBax-+brOy3s4xbSNG8Rd2UkwtPkPvv_=E0j=2pESwSsbOA@mail.gmail.com>
 <CANpVHHzZd=59HDQO+h-8EaK-EjuqEu4bnQLk7nF38tFUD8dkdw@mail.gmail.com>
From: Michal Mocny <mmocny@chromium.org>
Date: Wed, 3 Jul 2013 10:42:15 -0400
Message-ID: 
 <CAEeF2TfJFzj4c38_e4QW7NABNE-+gXvQ7LXt8aHKPYgs0ejSCg@mail.gmail.com>
Subject: Re: using node modules in cordova plugins?
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=047d7b6221b800952504e09c79f0

--047d7b6221b800952504e09c79f0
Content-Type: text/plain; charset=ISO-8859-1

Andrew and I had that conversation as few days ago, and he convinced me
that shipping code to end users should mean shipping with node_modules
(this sentiment is repeated from the creators of npm it seems).  That way,
any given users' node setup/platform version issues don't affect your code.
 Thus, I don't think npm install as a hook for plugman for install time is
necessary, not a good idea (at least not for this reason).

-Michal


On Wed, Jul 3, 2013 at 10:31 AM, Anis KADRI <anis.kadri@gmail.com> wrote:

> You could also ship your plugin as a node package (with a package.json and
> node_modules) and point your js paths to node_modules/ (just as +andrew
> said). Maybe plugman should also support before_ and after_ hooks as well
> in order to run "npm install" ?
>
>
> On Wed, Jul 3, 2013 at 9:59 AM, Bryan Bishop <kanzure@gmail.com> wrote:
>
> > On Tue, Jul 2, 2013 at 5:53 PM, Don Coleman <don.coleman@gmail.com>
> wrote:
> >
> > > I ripped a bunch of Javascript code out of my Cordova NFC plugin and
> > > created a NPM so I could reuse the code elsewhere.
> > >
> >
> > Is this something that runs on a phone? Does this mean you're running
> your
> > node module through browserify first?
> >
> > - Bryan
> > http://heybryan.org/
> > 1 512 203 0507
> >
>

--047d7b6221b800952504e09c79f0--