Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
Received-SPF: pass (nike.apache.org: domain of agrieve@google.com designates
 209.85.160.46 as permitted sender)
MIME-Version: 1.0
Sender: agrieve@google.com
In-Reply-To: <CE16A60C.22FCC%fil@adobe.com>
References: 
 <CABiQX1W51kJVZna-0=qPpgAQ3gB_5j4-=UAhto-ShY5-OjAZJQ@mail.gmail.com>
 <CE16A60C.22FCC%fil@adobe.com>
From: Andrew Grieve <agrieve@chromium.org>
Date: Thu, 25 Jul 2013 13:11:47 -0400
Message-ID: 
 <CABiQX1X23bgFxm1UW_rJjO0__Gxhnt8jC+D6rGrNRAn7Nxch_A@mail.gmail.com>
Subject: Re: Why CLI & Plugman are so slow
To: dev <dev@cordova.apache.org>
Content-Type: multipart/alternative; boundary=047d7b111c994a508104e2592093

--047d7b111c994a508104e2592093
Content-Type: text/plain; charset=ISO-8859-1

Looks like the fix is pretty easy:

agrieve@agrieve-macbookpro ~/git/cordova/tmp$ time node go3.js
went 0 times
went 10 times
went 20 times
went 30 times
went 40 times
went 50 times
went 60 times
went 70 times
went 80 times
went 90 times
went 100 times

real 0m0.444s
user 0m0.266s
sys 0m0.158s


All I did was replace "shelljs" with "shelljs-ffi".


On Thu, Jul 25, 2013 at 12:53 PM, Filip Maj <fil@adobe.com> wrote:

> Cool, nice work.
>
> We could either try to contribute to shelljs or rip it out and go all
> child process all the time
>
> In any case I think this bench should be submitted to shelljs repo. @r2r,
> dude who maintains it, would probably like to know
>
> On 7/25/13 9:50 AM, "Andrew Grieve" <agrieve@chromium.org> wrote:
>
> >One reason: shelljs.exec()
> >
> >Did a test to see how many times I could execute "true". 9 seconds vs .5
> >seconds!
> >
> >
> >agrieve@agrieve-macbookpro ~/git/cordova/tmp$ time node shelljstest.js
> >went 0 times
> >went 10 times
> >went 20 times
> >went 30 times
> >went 40 times
> >went 50 times
> >went 60 times
> >went 70 times
> >went 80 times
> >went 90 times
> >went 100 times
> >
> >real 0m8.873s
> >user 0m10.941s
> >sys 0m6.005s
> >agrieve@agrieve-macbookpro ~/git/cordova/tmp$ time node
> >child_processtest.js
> >went 10 times
> >went 20 times
> >went 30 times
> >went 40 times
> >went 50 times
> >went 60 times
> >went 70 times
> >went 80 times
> >went 90 times
> >went 100 times
> >
> >real 0m0.470s
> >user 0m0.278s
> >sys 0m0.228s
> >
> >
> >Here's the code:
> >shelljstest.js
> >
> >var shjs = require('shelljs');
> >> for (var i = 0; ; ++i) {
> >>     shjs.exec('true');
> >>     if ((i / 10 | 0) == i / 10) {
> >>       console.log('went ' + i + ' times');
> >>     }
> >>     if (i == 100) {
> >>       process.exit(0);
> >>     }
> >> }
> >
> >
> >child_processtest.js
> >
> >var child = require('child_process');
> >> var i = 0;
> >> function go() {
> >>   child.exec('true', function() {
> >>     ++i;
> >>     if ((i / 10 | 0) == i / 10) {
> >>       console.log('went ' + i + ' times');
> >>     }
> >>     if (i == 100) {
> >>       process.exit(0);
> >>     }
> >>     go();
> >>   });
> >> }
> >> go();
>
>

--047d7b111c994a508104e2592093--