Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1FBF510931 for ; Fri, 12 Jul 2013 17:29:13 +0000 (UTC) Received: (qmail 71174 invoked by uid 500); 12 Jul 2013 17:29:12 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 71152 invoked by uid 500); 12 Jul 2013 17:29:12 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 71131 invoked by uid 99); 12 Jul 2013 17:29:11 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jul 2013 17:29:11 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 473A41CEDB2; Fri, 12 Jul 2013 17:29:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8294002904494427886==" MIME-Version: 1.0 Subject: Re: Review Request 12514: Adding command to coho for creating release bugs. From: "Andrew Grieve" To: "Andrew Grieve" Cc: "Jeffrey Willms" , "cordova" Date: Fri, 12 Jul 2013 17:29:01 -0000 Message-ID: <20130712172901.14364.66527@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Andrew Grieve" X-ReviewGroup: cordova X-ReviewRequest-URL: https://reviews.apache.org/r/12514/ X-Sender: "Andrew Grieve" References: <20130712150532.14335.58817@reviews.apache.org> In-Reply-To: <20130712150532.14335.58817@reviews.apache.org> Reply-To: "Andrew Grieve" --===============8294002904494427886== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12514/#review23090 ----------------------------------------------------------- coho Having a "pretend" mode probably is a nice idea. Maybe add a flag for it? coho Might be nice to log() a status report here. Should use the print() function when doing so. e.g.: print('Creating issue: ' + issue.name) coho Insert. coho nit: use the fatal() helper instead of throwing. coho fatal() coho Remove - Andrew Grieve On July 12, 2013, 3:05 p.m., Jeffrey Willms wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12514/ > ----------------------------------------------------------- > > (Updated July 12, 2013, 3:05 p.m.) > > > Review request for cordova and Andrew Grieve. > > > Bugs: CB-4134 > https://issues.apache.org/jira/browse/CB-4134 > > > Repository: cordova-coho > > > Description > ------- > > Adding command to coho for creating release bugs. > > > Add .reviewboardrc. > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > coho b89742e0427f5fe15e8f10c00c5f38a8b7da42fa > > Diff: https://reviews.apache.org/r/12514/diff/ > > > Testing > ------- > > > Thanks, > > Jeffrey Willms > > --===============8294002904494427886==--