cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anis KADRI <anis.ka...@gmail.com>
Subject Re: Commit Issue
Date Sat, 27 Jul 2013 22:00:54 GMT
https://github.com/apache/cordova-android/pulls rather

On Sat, Jul 27, 2013 at 3:00 PM, Anis KADRI <anis.kadri@gmail.com> wrote:
> You want to open a new pull request on [1]. Not on your own repository.
>
> [1] https://github.com/apache/cordova-android
>
> On Sat, Jul 27, 2013 at 3:20 AM, Sharif Ahmed <sharifducse@gmail.com> wrote:
>> Hi,
>>
>> I have just made my first commit for jira issue:
>> https://issues.apache.org/jira/browse/CB-4410
>>
>> I have followed all the steps in the contributor work flow. I have one
>> question though.
>> My pull request appears to be in my forked cordova-android not the apache
>> cordova-android.
>>
>> Is this normal, or have I done something wrong?
>> In the docs it says: "By pushing your topic branch onto your fork, an
>> cordova-android maintainer can review and merge the topic branch into the
>> main repository."
>> I am confused.
>>
>> My pull request:
>> https://github.com/sharifahmed/cordova-android/pull/1
>>
>> Please let me know.
>>
>> Thanks.

Mime
View raw message