cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Gill <stevengil...@gmail.com>
Subject Re: failing tests on master
Date Tue, 09 Jul 2013 20:30:50 GMT
Just to clarify, I will be looking into cordova-js repo tests and not the
mobile spec tests.


On Tue, Jul 9, 2013 at 1:16 PM, David Kemp <drkemp@google.com> wrote:

> We are currently reviewing all the Android and iOS automatic tests in
> cordova-mobile-spec to ensure that they all run correctly.
> Some have been fixed quite recently (today).
>
> That of, course doesn't do anything for the unit tests, etc.
>
>
>
> On Tue, Jul 9, 2013 at 3:35 PM, Steven Gill <stevengill97@gmail.com>
> wrote:
>
> > I will take a look at removing all the tests that aren't applicable
> > anymore.
> >
> >
> > On Mon, Jul 8, 2013 at 1:44 PM, Andrew Grieve <agrieve@chromium.org>
> > wrote:
> >
> > > Yeah, I noticed that when I merged as well.
> > >
> > > Agree the device ones should just be removed for now. May be worth
> moving
> > > them to mobile-spec in the future.
> > >
> > >
> > > On Mon, Jul 8, 2013 at 4:31 PM, Joe Bowser <bowserj@gmail.com> wrote:
> > >
> > > > It appears that the tests are confined to Blackberry tests, and tests
> > > > for platforms that shouldn't exist because of Plugin Breakout.  The
> > > > plugin breakout should just remove those tests, but I'm still
> > > > wondering why Blackberry tests would have failed.
> > > >
> > > > On Mon, Jul 8, 2013 at 1:12 PM, Brian LeRoux <b@brian.io> wrote:
> > > > > cordova-js has a tonne of fails which should never happen given
> its a
> > > > > single command to run them
> > > > >
> > > > > On Mon, Jul 8, 2013 at 12:32 PM, Andrew Grieve <
> agrieve@chromium.org
> > >
> > > > wrote:
> > > > >> Not knowing which tests you're referring to... I can say that
many
> > > tests
> > > > >> were failing when I merged 3.0.0 branch into master. Seems
> > reasonable
> > > > that
> > > > >> this transition would have some failing tests along the way
> though.
> > > > >>
> > > > >>
> > > > >> On Mon, Jul 8, 2013 at 2:37 PM, Simon MacDonald
> > > > >> <simon.macdonald@gmail.com>wrote:
> > > > >>
> > > > >>> What, people aren't running the tests before checking in?
I for
> one
> > > am
> > > > >>> shocked :)
> > > > >>> Simon Mac Donald
> > > > >>> http://hi.im/simonmacdonald
> > > > >>>
> > > > >>>
> > > > >>> On Mon, Jul 8, 2013 at 3:32 PM, Brian LeRoux <b@brian.io>
wrote:
> > > > >>> > Shouldn't happen! Lets keep the dev mode stuff on a
branch then
> > to
> > > > >>> > master when the tests pass: PLS!
> > > > >>>
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message