cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Clelland <iclell...@google.com>
Subject Re: 3.0.0 Testing thread
Date Tue, 16 Jul 2013 19:16:58 GMT
Agreed. It's not random, but there's nothing in the process that guarantees
that. It should be tagged, and the tagged version should go out with the
-android repo.

Tag it (3.0.0rc2 -- or 3.0.0-rc2 to be semver-conformant), and you can
re-build and package it with cordova-android.


On Tue, Jul 16, 2013 at 3:14 PM, Joe Bowser <bowserj@gmail.com> wrote:

> I'm going to re-tag the JS. Since the only commit is this fix, none of
> the other platforms should need re-testing, but grabbing a random JS
> isn't the right way to do things, IMO.
>
> On Tue, Jul 16, 2013 at 11:58 AM, Ian Clelland <iclelland@chromium.org>
> wrote:
> > I've moved the latest cordova-js into cordova android, and pushed to
> > master. All of the mobilespec auto tests are passing for me. (With
> > mobile-spec-dependencies and all of its dependent plugins installed
> through
> > plugman)
> >
> > Ian
> >
> >
> > On Tue, Jul 16, 2013 at 2:45 PM, Ian Clelland <iclelland@google.com>
> wrote:
> >
> >> On Tue, Jul 16, 2013 at 2:42 PM, Joe Bowser <bowserj@gmail.com> wrote:
> >>
> >>> Has the issue been resolved, and is it plugin-related or is it part of
> >>> cordova-android?
> >>>
> >>
> >> Yes, no and maybe.
> >> That was the android bridge issue; cordova-js/lib/android/exec.js. It
> will
> >> be apart of cordova-android as soon as I package up the patched
> cordova-js
> >> and move it to cordova-android/framework/assets/www.
> >>
> >> Ian
> >>
> >>
> >>> On Tue, Jul 16, 2013 at 11:36 AM, Ian Clelland <iclelland@chromium.org
> >
> >>> wrote:
> >>> > That's right -- the issue was android-specific.
> >>> >
> >>> > Ian
> >>> >
> >>> >
> >>> > On Tue, Jul 16, 2013 at 2:32 PM, Shazron <shazron@gmail.com>
wrote:
> >>> >
> >>> >> No need to re-get and re-tag JS right for the other platforms?
> >>> >>
> >>> >>
> >>> >> On Tue, Jul 16, 2013 at 10:46 AM, Andrew Grieve <
> agrieve@chromium.org
> >>> >> >wrote:
> >>> >>
> >>> >> > Okay, seems it was a bad rebase when Ian made the base64 change.
> >>> Will be
> >>> >> > fixed shortly. Weird that these would pass at all for anyone
in
> the
> >>> past
> >>> >> > week!
> >>> >> >
> >>> >> >
> >>> >> > On Tue, Jul 16, 2013 at 1:27 PM, Andrew Grieve <
> agrieve@chromium.org
> >>> >
> >>> >> > wrote:
> >>> >> >
> >>> >> > > Okay - on my N4 4.2.2 they are failing as well. I'll
look into
> it.
> >>> >> > >
> >>> >> > >
> >>> >> > > On Tue, Jul 16, 2013 at 1:11 PM, Joe Bowser <bowserj@gmail.com>
> >>> wrote:
> >>> >> > >
> >>> >> > >> I'm testing on the HTC One running stock 4.2.2. The
Google one
> >>> without
> >>> >> > >> sense and the other crap.
> >>> >> > >>  On Jul 16, 2013 9:51 AM, "Andrew Grieve" <
> agrieve@chromium.org>
> >>> >> wrote:
> >>> >> > >>
> >>> >> > >> > Joe - what setup are you seeing the failures
for? I'm running
> >>> latest
> >>> >> > >> > everything and on 4.1.1 emulator all file tests
pass.
> >>> >> > >> >
> >>> >> > >> > Shouldn't be related to ResourceApi change,
as the File
> plugin
> >>> >> doesn't
> >>> >> > >> use
> >>> >> > >> > it.
> >>> >> > >> >
> >>> >> > >> >
> >>> >> > >> > On Tue, Jul 16, 2013 at 11:51 AM, Filip Maj
<fil@adobe.com>
> >>> wrote:
> >>> >> > >> >
> >>> >> > >> > > Yes, when you clone down either of the
tools, ALWAYS run
> `npm
> >>> >> > >> install` in
> >>> >> > >> > > its directory to reinitialize the dependencies.
Even when
> just
> >>> >> > >> updating
> >>> >> > >> > > the code for the tools, run `npm install`
just in case in
> >>> case the
> >>> >> > >> deps
> >>> >> > >> > > changed
> >>> >> > >> > >
> >>> >> > >> > > On 7/16/13 8:06 AM, "Shazron" <shazron@gmail.com>
wrote:
> >>> >> > >> > >
> >>> >> > >> > > >aha, cordova-cli specified plugman
0.9.3 -- and that
> works.
> >>> It's
> >>> >> a
> >>> >> > >> bug
> >>> >> > >> > > >when
> >>> >> > >> > > >cordova-cli uses the latest plugman
> >>> >> > >> > > >
> >>> >> > >> > > >
> >>> >> > >> > > >
> >>> >> > >> > > >On Tue, Jul 16, 2013 at 8:03 AM, David
Kemp <
> >>> drkemp@google.com>
> >>> >> > >> wrote:
> >>> >> > >> > > >
> >>> >> > >> > > >> I had the same error that you
got, but running npm
> install
> >>> in
> >>> >> the
> >>> >> > >> > > >> cordova-cli directory installed
a fresh one (not sure
> which
> >>> >> > >> version )
> >>> >> > >> > > >>and
> >>> >> > >> > > >> everything worked fine
> >>> >> > >> > > >>
> >>> >> > >> > > >>
> >>> >> > >> > > >> On Tue, Jul 16, 2013 at 10:50
AM, Shazron <
> >>> shazron@gmail.com>
> >>> >> > >> wrote:
> >>> >> > >> > > >>
> >>> >> > >> > > >> > I installed plugman 0.9.6
before using cordova-cli
> from
> >>> >> master,
> >>> >> > >> and
> >>> >> > >> > > >>that
> >>> >> > >> > > >> is
> >>> >> > >> > > >> > the latest on npm - but I
assume you mean the latest
> >>> from the
> >>> >> > >> > > >> > cordova-plugman repo
> >>> >> > >> > > >> >
> >>> >> > >> > > >> >
> >>> >> > >> > > >> > On Tue, Jul 16, 2013 at 7:42
AM, David Kemp <
> >>> >> drkemp@google.com
> >>> >> > >
> >>> >> > >> > > wrote:
> >>> >> > >> > > >> >
> >>> >> > >> > > >> > > the newest cli needs
the newest plugman.
> >>> >> > >> > > >> > > Also if you uninstall
plugins with the older
> version,
> >>> the
> >>> >> new
> >>> >> > >> one
> >>> >> > >> > > >>wont
> >>> >> > >> > > >> > put
> >>> >> > >> > > >> > > them in.
> >>> >> > >> > > >> > >
> >>> >> > >> > > >> > >
> >>> >> > >> > > >> > >
> >>> >> > >> > > >> > > On Tue, Jul 16, 2013
at 10:27 AM, Shazron <
> >>> >> shazron@gmail.com
> >>> >> > >
> >>> >> > >> > > wrote:
> >>> >> > >> > > >> > >
> >>> >> > >> > > >> > > > I'm using the master
version of the cordova-cli,
> >>> >> > installing a
> >>> >> > >> > > >>plugin
> >>> >> > >> > > >> is
> >>> >> > >> > > >> > > > fine, but uninstall
throws this error:
> >>> >> > >> > > >> > > >
> >>> >> > >> > > >> > > > $ ../cordova-cli/bin/cordova
plugin remove
> >>> >> > >> > > >> > > org.apache.cordova.core.console
> >>> >> > >> > > >> > > > [TypeError: Object
function
> uninstallPlugin(platform,
> >>> >> > >> > project_dir,
> >>> >> > >> > > >> id,
> >>> >> > >> > > >> > > > plugins_dir, options,
callback) {
> >>> >> > >> > > >> > > >     if (!platform_modules[platform])
{
> >>> >> > >> > > >> > > >         var err
= new Error(platform + " not
> >>> >> supported.");
> >>> >> > >> > > >> > > >         if (callback)
return callback(err);
> >>> >> > >> > > >> > > >         else throw
err;
> >>> >> > >> > > >> > > >     }
> >>> >> > >> > > >> > > >
> >>> >> > >> > > >> > > >     var plugin_dir
= path.join(plugins_dir, id);
> >>> >> > >> > > >> > > >
> >>> >> > >> > > >> > > >     if (!fs.existsSync(plugin_dir))
{
> >>> >> > >> > > >> > > >         var err
= new Error('Plugin "' + id + '"
> not
> >>> >> found.
> >>> >> > >> > > >>Already
> >>> >> > >> > > >> > > > uninstalled?');
> >>> >> > >> > > >> > > >         if (callback)
return callback(err);
> >>> >> > >> > > >> > > >         else throw
err;
> >>> >> > >> > > >> > > >     }
> >>> >> > >> > > >> > > >
> >>> >> > >> > > >> > > >     var current_stack
= new action_stack();
> >>> >> > >> > > >> > > >
> >>> >> > >> > > >> > > >     options.is_top_level
= true;
> >>> >> > >> > > >> > > >     runUninstall(current_stack,
platform,
> >>> project_dir,
> >>> >> > >> > plugin_dir,
> >>> >> > >> > > >> > > > plugins_dir, options,
callback);
> >>> >> > >> > > >> > > > } has no method
'uninstallPlatform']
> >>> >> > >> > > >> > > >
> >>> >> > >> > > >> > > >
> >>> >> > >> > > >> > > >
> >>> >> > >> > > >> > > > On Tue, Jul 16,
2013 at 7:21 AM, Joe Bowser <
> >>> >> > >> bowserj@gmail.com>
> >>> >> > >> > > >> wrote:
> >>> >> > >> > > >> > > >
> >>> >> > >> > > >> > > > > Has anyone
managed to get plugman to uninstall a
> >>> >> plugin?
> >>> >> > >> The
> >>> >> > >> > > >> > > > > dependencies
plugin never cleanly installs or
> >>> >> uninstalls.
> >>> >> > >> > > >> > > > >
> >>> >> > >> > > >> > > > > On Tue, Jul
16, 2013 at 6:37 AM, Shazron <
> >>> >> > >> shazron@gmail.com>
> >>> >> > >> > > >> wrote:
> >>> >> > >> > > >> > > > > > https://issues.apache.org/jira/browse/CB-4264
> >>> >> > >> > > >> > > > > >
> >>> >> > >> > > >> > > > > > Turns
out it was a "false positive" failure,
> the
> >>> test
> >>> >> > >> needs
> >>> >> > >> > > >>to be
> >>> >> > >> > > >> > > > > improved.
> >>> >> > >> > > >> > > > > > But so
far all systems go for iOS.
> >>> >> > >> > > >> > > > > >
> >>> >> > >> > > >> > > > > >
> >>> >> > >> > > >> > > > > > On Mon,
Jul 15, 2013 at 6:54 PM, Shazron <
> >>> >> > >> shazron@gmail.com
> >>> >> > >> > >
> >>> >> > >> > > >> > wrote:
> >>> >> > >> > > >> > > > > >
> >>> >> > >> > > >> > > > > >> So
far I went and tested with the plugins
> >>> (specified
> >>> >> > in
> >>> >> > >> the
> >>> >> > >> > > >> > > > > >> dependencies-plugin
on cordova-mobile-spec)
> on
> >>> >> master
> >>> >> > >> for
> >>> >> > >> > > >>iOS,
> >>> >> > >> > > >> > with
> >>> >> > >> > > >> > > 1
> >>> >> > >> > > >> > > > > test
> >>> >> > >> > > >> > > > > >> failing:
> >>> >> > >> > > >> > > > > >>
> >>> >> > >> > > >> > > > > >> File
API DirectoryReader interface
> readEntries
> >>> >> > >> > file.spec.109
> >>> >> > >> > > >> > should
> >>> >> > >> > > >> > > > > return
> >>> >> > >> > > >> > > > > >> an
empty entry list on the second call.
> >>> >> > >> > > >> > > > > >> Expected
0 not to be 0.
> >>> >> > >> > > >> > > > > >>
> >>> >> > >> > > >> > > > >
> >>> >> > >> > > >> > > >
> >>> >> > >> > > >> > >
> >>> >> > >> > > >> >
> >>> >> > >> > > >>
> >>> >> > >> > >
> >>> >> > >> > >
> >>> >> > >> >
> >>> >> > >>
> >>> >> > >
> >>> >> > >
> >>> >> >
> >>> >>
> >>>
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message