cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlos Santana <csantan...@gmail.com>
Subject Re: Cordova Blog
Date Tue, 09 Jul 2013 15:45:44 GMT
ah I see, thanks for the explanation

Cool I see it now duh!

cordova-docs:(master)$ cat .reviewboardrc
#
# Settings for post-review (used for uploading diffs to reviews.apache.org).
#
GUESS_FIELDS = True
OPEN_BROWSER = True
TARGET_GROUPS = 'cordova'
REVIEWBOARD_URL = 'http://reviews.apache.org'




On Tue, Jul 9, 2013 at 10:39 AM, Andrew Grieve <agrieve@chromium.org> wrote:

> post-review is what rbtools is going to replacing. I haven't tried rbtools
> yet. .reviewboard is meant to be checked in to each repo and read by
> post-review / rbtools. Using github vs. reviewboard are both valid right
> avenues right now for code review. The idea behind introducing reviewboard
> is that it's apache hosted and doesn't require cloning the repos onto
> github. Github's review process is also not the best (diff view hides
> things on you, and every comment results in an email)
>
>
> On Tue, Jul 9, 2013 at 10:28 AM, Michal Mocny <mmocny@chromium.org> wrote:
>
> > I can't see your attached image, but previously you said you saw 3
> reviews?
> >  I think thats just all of them at the moment ;)
> >
> >
> > On Tue, Jul 9, 2013 at 10:20 AM, Carlos Santana <csantana23@gmail.com
> > >wrote:
> >
> > > Michal
> > >   I can see the cordova repos when creating a new request.
> > >
> > > How do you get a view with all reviews associated with all the cordova
> > > repos?
> > >
> > > On the "My Dashboard" I'm looking to see all reviews associated with
> > > cordova repos, but I don't see them
> > > https://reviews.apache.org/dashboard/?view=to-group&group=cordova
> > >
> > > [image: Inline image 2]
> > >
> > >
> > >
> > >
> > > On Tue, Jul 9, 2013 at 10:13 AM, Michal Mocny <mmocny@chromium.org>
> > wrote:
> > >
> > >> Carlos, what are you looking *for*?
> > >>
> > >> When I go to create a new review request, I see a list of cordova
> repos,
> > >> including "cordova-site".
> > >>
> > >>
> > >> On Tue, Jul 9, 2013 at 10:04 AM, Carlos Santana <csantana23@gmail.com
> > >> >wrote:
> > >>
> > >> > Hum maybe I'm looking in the wrong place.
> > >> >
> > >> > I go to Groups and I only see one "cordova"
> > >> > https://reviews.apache.org/groups/
> > >> > https://reviews.apache.org/groups/cordova/
> > >> >
> > >> > I got to "My Account" seetings and I can only add one group
> "cordova"
> > >> > Which groups do you belong to or wish to watch?
> > >> > [] cordova
> > >> >
> > >> > Maybe the problem is that folks are not setting the "Group" field
to
> > >> > "cordova" when they do a new Request?
> > >> > Could this be a required field when the repository starts with
> > >> "cordova*" ?
> > >> >
> > >> > --Carlos
> > >> >
> > >> >
> > >> >
> > >> > On Tue, Jul 9, 2013 at 9:38 AM, Michal Mocny <mmocny@chromium.org>
> > >> wrote:
> > >> >
> > >> > > reviews.apache.org is just a place to submit patches for review,
> > >> manage
> > >> > > comments on lines of code etc.
> > >> > >
> > >> > > Some of us have started using it to organize reviews of patches.
> >  Its
> > >> not
> > >> > > the most beautiful interface, but it serves its purpose.
> > >> > >
> > >> > > I just tried it and submitting a new review I see many more than
> > three
> > >> > > items (heck, cordova itself has like 20 repositories now).
> > >> > >
> > >> > > We probably should mention it in the workflow, but its not a
> > mandatory
> > >> > > item, just a tool for those who are interested.
> > >> > >
> > >> > > -Michal
> > >> > >
> > >> > >
> > >> > > On Tue, Jul 9, 2013 at 9:31 AM, Carlos Santana <
> > csantana23@gmail.com>
> > >> > > wrote:
> > >> > >
> > >> > > > Thanks Andrew
> > >> > > >
> > >> > > > What's the deal with https://reviews.apache.org ? I found
it
> > empty
> > >> > > (i.e. 3
> > >> > > > items)
> > >> > > >
> > >> > > > Is the Apache Cordova project migrating to it soon?, people
> don't
> > >> know
> > >> > > > about it?
> > >> > > >
> > >> > > > If the Cordova Project wants to make it part fo the dev
workflow
> > it
> > >> > might
> > >> > > > help to document it on the Wiki
> > >> > > > http://wiki.apache.org/cordova/ContributorWorkflow
> > >> > > >
> > >> > > > I try using it and I failed, if someone can write a short
cheat
> > for
> > >> it
> > >> > > that
> > >> > > > will be awesome.
> > >> > > >
> > >> > > > -Carlos
> > >> > > >
> > >> > > >
> > >> > > > On Mon, Jul 8, 2013 at 9:36 PM, Andrew Grieve <
> > agrieve@chromium.org
> > >> >
> > >> > > > wrote:
> > >> > > >
> > >> > > > > I got the site added to review.apache.org, so in the
future
> we
> > >> can
> > >> > use
> > >> > > > > that
> > >> > > > > for reviewing changes / new blog posts.
> > >> > > > >
> > >> > > > > I'll apply your patch tomorrow :).
> > >> > > > >
> > >> > > > >
> > >> > > > > On Mon, Jul 8, 2013 at 5:33 PM, Carlos Santana <
> > >> csantana23@gmail.com
> > >> > >
> > >> > > > > wrote:
> > >> > > > >
> > >> > > > > > I'm good for staging and review new features on
GitHub Pages
> > >> before
> > >> > > > > pushing
> > >> > > > > > live content to svn/infra
> > >> > > > > >
> > >> > > > > >
> > >> > > > > > On Mon, Jul 8, 2013 at 5:16 PM, Brian LeRoux <b@brian.io>
> > >> wrote:
> > >> > > > > >
> > >> > > > > > > > Did I forgot to say I don't love SVN.
> > >> > > > > > >
> > >> > > > > > > Ya.
> > >> > > > > > >
> > >> > > > > > >
> > >> > > > > > > > Can we host this on gtihub pages and
maintain the
> website
> > on
> > >> > > > Github,
> > >> > > > > > and
> > >> > > > > > > > let github run jekyll on the source
code?
> > >> > > > > > >
> > >> > > > > > > Unfortunately no. We could use Github for
'staging' I
> guess.
> > >> > > > > > >
> > >> > > > > > >
> > >> > > > > > > > Downloads and Docs files will still
be available from
> > >> > > > > > > > http://cordova.apache.org/downloads
and
> > >> > > > > > http://cordova.apache.org/docsbut
> > >> > > > > > > > the website and blog will live in Github.
> > >> > > > > > >
> > >> > > > > > > Again, no. The website needs to be on Apache
infra. =/
> > >> > > > > > >
> > >> > > > > >
> > >> > > > > >
> > >> > > > > >
> > >> > > > > > --
> > >> > > > > > Carlos Santana
> > >> > > > > > <csantana23@gmail.com>
> > >> > > > > >
> > >> > > > >
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > > --
> > >> > > > Carlos Santana
> > >> > > > <csantana23@gmail.com>
> > >> > > >
> > >> > >
> > >> >
> > >> >
> > >> >
> > >> > --
> > >> > Carlos Santana
> > >> > <csantana23@gmail.com>
> > >> >
> > >>
> > >
> > >
> > >
> > > --
> > > Carlos Santana
> > > <csantana23@gmail.com>
> > >
> >
>



-- 
Carlos Santana
<csantana23@gmail.com>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message