cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bryan Higgins <br...@bryanhiggins.net>
Subject Re: FileTransfer plugin broken
Date Mon, 15 Jul 2013 21:08:13 GMT
The fix is here:
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;a=commitdiff;h=34fd9247ff6992f0b4ae0d1e61516ff52bc7aed8;hp=d39016ecb216b7f317ac6c76b2dcf4e11d34b69c


On Mon, Jul 15, 2013 at 4:22 PM, David Kemp <drkemp@google.com> wrote:

> I have not. its all yours
>
>
>
> On Mon, Jul 15, 2013 at 4:20 PM, Bryan Higgins <bryan@bryanhiggins.net
> >wrote:
>
> > Looks like a merge problem. I'll fix it. Did anyone open an issue?
> >
> >
> > On Mon, Jul 15, 2013 at 3:43 PM, Andrew Grieve <agrieve@chromium.org>
> > wrote:
> >
> > > It should use a relative require: require('./FileTransferError')
> > >
> > >
> > > On Mon, Jul 15, 2013 at 3:28 PM, David Kemp <drkemp@google.com> wrote:
> > >
> > > > the commit a few hours ago :
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/apache/cordova-plugin-file-transfer/commit/d39016ecb216b7f317ac6c76b2dcf4e11d34b69c
> > > >
> > > > Specifies the
> > > >
> > > > FileTransferError =
> > > > require('org.apache.cordova.core.FileTransfer.FileTransferError'),
> > > >
> > > > Which doesn't work since thats not where it is.
> > > >
> > > > I am assuming that file-transfer is the expected location (unless
> > someone
> > > > plans to rename the directories...)
> > > >
> > > > so it should be:
> > > >
> > > > FileTransferError =
> > > > require('org.apache.cordova.core.file-transfer.FileTransferError'),
> > > >
> > > > Is this just an error, or was there some other work planned?
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message