cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Max Woghiren <m...@chromium.org>
Subject Re: Cordova Android Commit Needs Review
Date Tue, 30 Jul 2013 15:27:54 GMT
I've committed your work.  Thanks!  Please close the pull request in GitHub.


On Tue, Jul 30, 2013 at 5:17 AM, Sharif Ahmed <sharifducse@gmail.com> wrote:

> Hi,
>
> I have submitted the ICLA.
>
> It is now safe to merge my commits.
>
> Thanks :)
>
>
> On Mon, Jul 29, 2013 at 9:12 PM, Sharif Ahmed <sharifducse@gmail.com>
> wrote:
>
> > Yes yes, I totally overlooked.
> >
> > Ok I will do it by tomorrow and let you guys know.
> >
> > Thanks for reminder me :)
> >
> >
> > On Mon, Jul 29, 2013 at 8:15 PM, Andrew Grieve <agrieve@chromium.org
> >wrote:
> >
> >> Sharif, fixes look good. I think you need to sign the Apache ICLA before
> >> we
> >> can pull the code in though:
> >>
> >> http://www.apache.org/licenses/#clas
> >>
> >> As noted on: http://wiki.apache.org/cordova/ContributorWorkflow
> >>
> >>
> >>
> >> On Sun, Jul 28, 2013 at 3:22 AM, Sharif Ahmed <sharifducse@gmail.com>
> >> wrote:
> >>
> >> > Hi,
> >> >
> >> > Need a review to my recent commit:
> >> > https://github.com/apache/cordova-android/pull/76
> >> >
> >> > Jira Issue:
> >> > https://issues.apache.org/jira/browse/CB-4410
> >> >
> >> > Thanks.
> >> >
> >>
> >
> >
> >
> > --
> > Regards,
> >
> > Sharif Ahmed
> > Junior Software Engineer
> > Therap Services, LLC
> > +01715438290
> >
> >
>
>
> --
> Regards,
>
> Sharif Ahmed
> Junior Software Engineer
> Therap Services, LLC
> +01715438290
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message