cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Clelland" <iclell...@chromium.org>
Subject Re: Review Request 12668: Unified whitelist implementation for iOS
Date Wed, 17 Jul 2013 15:42:39 GMT


> On July 17, 2013, 3:05 p.m., Andrew Grieve wrote:
> > CordovaLib/Classes/CDVWhitelist.m, line 174
> > <https://reviews.apache.org/r/12668/diff/1/?file=322547#file322547line174>
> >
> >     why remove? maybe at least replace with a comment.

Removed because (whitelist==nil) is now the condition under which all urls are *allowed*.

The diff is matching similar-looking lines, but what used to be a runtime check that 'nil'
wasn't passed in to the init method is now a shortcut return on addWhiteListEntry in case
"*" has already been encountered.

I can still log that on initWithArray in the case that array is nil, but I don't think that
this can happen in a real application now. (At the very least, the CDVConfigParser will add
a three url patterns to any new config).


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12668/#review23280
-----------------------------------------------------------


On July 17, 2013, 1:20 p.m., Ian Clelland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12668/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 1:20 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Repository: cordova-ios
> 
> 
> Description
> -------
> 
> CB-4095: This implements the new unified whitelist for iOS. 
> 
> 
> Diffs
> -----
> 
>   CordovaLib/Classes/CDVConfigParser.m c06b7f7 
>   CordovaLib/Classes/CDVWhitelist.m e6807bd 
> 
> Diff: https://reviews.apache.org/r/12668/diff/
> 
> 
> Testing
> -------
> 
> All mobilespec whitelist-related tests pass with this implementation
> 
> 
> Thanks,
> 
> Ian Clelland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message