cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Clelland" <iclell...@chromium.org>
Subject Re: Review Request 12548: Unify whitelist implementations: Android implementation
Date Wed, 17 Jul 2013 15:22:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12548/
-----------------------------------------------------------

(Updated July 17, 2013, 3:22 p.m.)


Review request for cordova.


Changes
-------

Uploading the *real* diff file this time.


Repository: cordova-android-git


Description
-------

Replaced the current android whitelist implementation with a new one which conforms to CB-4093.

This is also more robust against bad urls in the config file, and handles several cases which
the previous implementation did not (eg. http://www.apache.org:password@evil.com/ would be
accepted previously)


Diffs (updated)
-----

  framework/src/org/apache/cordova/Config.java 6e0c147 
  framework/src/org/apache/cordova/Whitelist.java 736e5a7 

Diff: https://reviews.apache.org/r/12548/diff/


Testing
-------

This passes all of the recently-added whitelist tests in cordova-mobile-spec.


Thanks,

Ian Clelland


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message