cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve" <agri...@chromium.org>
Subject Re: Review Request 12668: Unified whitelist implementation for iOS
Date Wed, 17 Jul 2013 15:05:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12668/#review23280
-----------------------------------------------------------



CordovaLib/Classes/CDVWhitelist.m
<https://reviews.apache.org/r/12668/#comment47169>

    Instead of using properties, use fields:
    
    @interface CDVWhitelistPattern : NSObject {
     @private
      NSRegularExpression* scheme;
    }
    
    Don't forget to run this through uncrustify before committing (bin/uncrustify.sh)



CordovaLib/Classes/CDVWhitelist.m
<https://reviews.apache.org/r/12668/#comment47170>

    why remove? maybe at least replace with a comment.



CordovaLib/Classes/CDVWhitelist.m
<https://reviews.apache.org/r/12668/#comment47171>

    initialize these to nil.


- Andrew Grieve


On July 17, 2013, 1:20 p.m., Ian Clelland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12668/
> -----------------------------------------------------------
> 
> (Updated July 17, 2013, 1:20 p.m.)
> 
> 
> Review request for cordova.
> 
> 
> Repository: cordova-ios
> 
> 
> Description
> -------
> 
> CB-4095: This implements the new unified whitelist for iOS. 
> 
> 
> Diffs
> -----
> 
>   CordovaLib/Classes/CDVConfigParser.m c06b7f7 
>   CordovaLib/Classes/CDVWhitelist.m e6807bd 
> 
> Diff: https://reviews.apache.org/r/12668/diff/
> 
> 
> Testing
> -------
> 
> All mobilespec whitelist-related tests pass with this implementation
> 
> 
> Thanks,
> 
> Ian Clelland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message