cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve" <agri...@chromium.org>
Subject Re: Review Request 12514: Adding command to coho for creating release bugs.
Date Fri, 12 Jul 2013 17:29:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12514/#review23090
-----------------------------------------------------------



coho
<https://reviews.apache.org/r/12514/#comment46882>

    Having a "pretend" mode probably is a nice idea. Maybe add a flag for it?



coho
<https://reviews.apache.org/r/12514/#comment46883>

    Might be nice to log() a status report here. Should use the print() function when doing
so. e.g.:
    
    print('Creating issue: ' + issue.name)



coho
<https://reviews.apache.org/r/12514/#comment46879>

    Insert.



coho
<https://reviews.apache.org/r/12514/#comment46880>

    nit: use the fatal() helper instead of throwing.



coho
<https://reviews.apache.org/r/12514/#comment46881>

    fatal()



coho
<https://reviews.apache.org/r/12514/#comment46884>

    Remove


- Andrew Grieve


On July 12, 2013, 3:05 p.m., Jeffrey Willms wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12514/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 3:05 p.m.)
> 
> 
> Review request for cordova and Andrew Grieve.
> 
> 
> Bugs: CB-4134
>     https://issues.apache.org/jira/browse/CB-4134
> 
> 
> Repository: cordova-coho
> 
> 
> Description
> -------
> 
> Adding command to coho for creating release bugs.
> 
> 
> Add .reviewboardrc.
> 
> 
> Diffs
> -----
> 
>   .reviewboardrc PRE-CREATION 
>   coho b89742e0427f5fe15e8f10c00c5f38a8b7da42fa 
> 
> Diff: https://reviews.apache.org/r/12514/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jeffrey Willms
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message